Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further plot updates and fix observed contour lines #185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dabail10
Copy link
Collaborator

@dabail10 dabail10 commented Feb 4, 2025

Description of changes:

  • Please add an explanation of what your changes do and why you'd like us to include them.
  • Fix the observed contour lines in the spatial plots.
  • add back in import of nc_time_axis
  • Add the "maximum" ice concentration for contour plots and Labrador Sea plots

All PRs Checklist:

New notebook PR Additional Checklist (if these do not apply, feel free to remove this section):

  • Have you hidden the code cells (#8 in Adding Notebooks Guide) in your notebook?
  • Have you removed any unused parameters from your cell tagged with parameters? These can cause confusing warnings that show up as DAG build with warnings.
  • Have you moved any observational data that you are using to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data and ensured that it follows this format within that directory: COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?

Copy link
Collaborator

@TeaganKing TeaganKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you still want to make additional changes or if this is ready?

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment about the directory structure of the obs datasets, I'm a little confused about how path_nsidc is defined inside plot_diff.py. Can this be an argument passed in from the notebook, so this function works on computers that don't have access to campaign store? A couple of related questions:

  1. is path_nsidc the right variable name? (Is this still NSIDC data? Isn't HadOIBl coming from UKMO?)
  2. Should we have something like obs_data_root that is set to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets in config.yml and then we build up all the other path_ variables from that? path_nsidc = os.path.join(obs_data_root, 'hemispheric_data', 'NSIDC_SeaIce_extent'), path_hadoibl = os.path.join(obs_data_root, '1x1', 'HadOIBl'), etc?

This might require a little clean up in the other ice notebooks and .py files, but it will set a good precedent for later updates

ds_obs = xr.open_dataset(path_nsidc + "SSMI.ifrac.1981-2005monthlymean.gx1v5.nc")

ds_pop = add_cyclic(ds_obs)
ds_obs = xr.open_dataset(path_nsidc + "sst_HadOIBl_bc_1x1_climo_1980_2019.nc")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you added the 1x1 files to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice; can we move them to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/1x1? (The analysis_datasets/ directory exists, but the 1x1/ subdirectory does not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants