-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further plot updates and fix observed contour lines #185
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you still want to make additional changes or if this is ready?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comment about the directory structure of the obs datasets, I'm a little confused about how path_nsidc
is defined inside plot_diff.py
. Can this be an argument passed in from the notebook, so this function works on computers that don't have access to campaign store? A couple of related questions:
- is
path_nsidc
the right variable name? (Is this still NSIDC data? Isn'tHadOIBl
coming from UKMO?) - Should we have something like
obs_data_root
that is set to/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets
inconfig.yml
and then we build up all the otherpath_
variables from that?path_nsidc = os.path.join(obs_data_root, 'hemispheric_data', 'NSIDC_SeaIce_extent')
,path_hadoibl = os.path.join(obs_data_root, '1x1', 'HadOIBl')
, etc?
This might require a little clean up in the other ice notebooks and .py
files, but it will set a good precedent for later updates
nblibrary/ice/plot_diff.py
Outdated
ds_obs = xr.open_dataset(path_nsidc + "SSMI.ifrac.1981-2005monthlymean.gx1v5.nc") | ||
|
||
ds_pop = add_cyclic(ds_obs) | ||
ds_obs = xr.open_dataset(path_nsidc + "sst_HadOIBl_bc_1x1_climo_1980_2019.nc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you added the 1x1 files to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice
; can we move them to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/1x1
? (The analysis_datasets/
directory exists, but the 1x1/
subdirectory does not)
Description of changes:
All PRs Checklist:
pre-commit
checks passed (#8 in Adding Notebooks Guide)?New notebook PR Additional Checklist (if these do not apply, feel free to remove this section):
parameters
? These can cause confusing warnings that show up asDAG build with warnings
./glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data
and ensured that it follows this format within that directory:COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE
?