Recent WRF-Hydro Developments #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new perfect model obs experimental capability is added to HydroDART. The python and shell scripts use a user-defined truth run to sample psuedo-observations and run OSSEs. The following scripts have been tested in regional hydroDART runs such as the DRB domain. 1- gen_truth.sh: Starting from a list of wrf-hydro restarts (truth), strip out streamflow information at all available routelink gauges or at a subset of gauges specified by the user. The resulting netcdf files are stored in a new directory. 2- gauges.sh: A script to handle the gauges in the domain. It can be used to identify a subset "desired" set of gauges or retrive all gauges available in wrf_hydro's Routelink file. 3- pmo_osse.py: This iterates over the truth files obtained by running 'gen_truth.sh' and builds a set of obs sequence files. These are then used by the hydroDART famework to conduct an OSSE. Credits to Ben Johnson who built initial versions of this script. PS. This could have been done by building a wrapper around DART's own perfect_model_obs routine. The reasons why we went this route are unknown at this time.
Streamflow obs converter is modified to allow for better diagnostics. The changes allows DART to compute obs space diagnostics on all gauges from the Routelink (not only the ones specified by the user). This essentially mimcs evaluate_only functionality for non-idenity obs. There is also a change to check for bad (inf/nan) streamflow obs. A final change allows processing a large number of obs-seq files at the same time. The python scripts include bug fixes for file movement. It also allows to call the converter from the yaml file using fat memory nodes.
Changes to the model_mod and noah_hydro_mod to enhance performance when running a full CONUS domain. Various parts of the noah_hydro_mod code are rearranged to avoid extra computations that are not needed when the LSM is turned off. Also, the link tree structure is modified such that only the individual upstream links from any reach are stored. We also limit the number of upstream links to '5'. This helps alleviate any issues in the Routelink file (which can make the stream network unphysical). This change makes our Along-The-Stream (ATS) Localization runs a lot faster. Changes in the model_mod makes the code faster when distributing the close by reaches to each individual task. Also, there is a change that allows reading climatology files when a hybrid EnKF variant is invoked.
Modifications to hydroDART's diagnostic routine now allows the following: 1. Save the hydrographs in a high-resolution pdf 2. Handles hybrid DA components (weight mean and sd) 3. Better parsing of the netcdf files 4. Allows the openloop to have different ens size (compared to the regular DA runs) 5. Better time handling 6. Collects more information about the openloop run 7. The openloop may have different gauges than the DA runs 8. Better usage of matlab functions (removing obselete ones) 9. Separate plots for the hybrid statistics
|
Hi Moha, checking in with what you're looking for in this review. Anything in particular you want reviewers to take a close look at? Cheers, |
|
@hkershaw-brown I would like mainly the 'enhanced performance' commit to be looked at. The other commits are less important and have been tested extensively. The enhanced performance commit has changes to model-mod and noah-hydro-mod to accelerate several computations. Please let me know if you have any questions. |
hkershaw-brown
requested changes
Mar 11, 2024
models/wrf_hydro/noah_hydro_mod.f90
Outdated
Comment on lines
1047
to
1052
| !io = nf90_inq_varid(ncid,'gages', VarID) | ||
| !call nc_check(io, routine, 'inq_varid', 'gages', filename) | ||
| !io = nf90_get_var(ncid, VarID, gageID) | ||
| !call nc_check(io, routine, 'get_var', 'gages', filename) | ||
|
|
||
| !call nc_close_file(ncid, routine) |
There was a problem hiding this comment.
There are quite a few commented out lines of code. It would be better to remove the code if it is not being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
Fixes issue
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Checklist for merging
Checklist for release
Testing Datasets