Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent hang by erroring out if shortest_time_between_assimilations <=0 #713

Merged
merged 2 commits into from
Aug 29, 2024
Merged

prevent hang by erroring out if shortest_time_between_assimilations <=0 #713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91c7514
fix: error out if shortest_time_between_assimilations <=0
hkershaw-brown Aug 9, 2024
752abd1
Merge branch 'main' into fix-zero-window
hkershaw-brown Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions assimilation_code/modules/assimilation/obs_model_mod.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ subroutine move_ahead(ens_handle, ens_size, seq, last_key_used, window_time, &

! Compute the model time step and center a window around the closest time
delta_time = get_model_time_step()
if (delta_time <= set_time(0,0)) then
call error_handler(E_ERR, 'move_ahead', 'shortest_time_between_assimilations must be > 0', source)
endif

! print out current window, if requested
if (print_trace_details > 0) then
Expand Down