Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test_obs directory - not used (built or run) #795

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

hkershaw-brown
Copy link
Member

Description:

code not used
Looks like the original code was/intended for creating data for obs_diag.
Discovered when I was updating the build system. Conservatively kept it in at that time. The code has not been in use for some time, so removing it rather than having dead code (not built, not run) around.

Fixes issue

fixes #220

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • dead code removal

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Compiled everything in DART, grepped around for anything that was including the code.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown added the dead-code code not used or does nothing label Jan 14, 2025
Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jan 21, 2025
@hkershaw-brown hkershaw-brown merged commit 24e80d4 into main Jan 22, 2025
95 of 96 checks passed
@hkershaw-brown hkershaw-brown deleted the remove-test_obs branch January 22, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dead-code code not used or does nothing release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: make_fake_obs array mismatch
2 participants