Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-pin ASV #569

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Re-pin ASV #569

merged 2 commits into from
Feb 27, 2024

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Feb 27, 2024 •
edited
Loading

PR Summary

Bandaid for #555

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@anissa111 anissa111 added bug Something isn't working dependencies Pull requests that update a dependency file testing Issue related to testing labels Feb 27, 2024
kafitzgerald
kafitzgerald approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Re-pinning for now seems fine though.

@anissa111 anissa111 merged commit d3f6dee into NCAR:main Feb 27, 2024
15 checks passed
@anissa111 anissa111 deleted the repin-asv branch February 27, 2024 22:08
@anissa111 anissa111 mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kafitzgerald kafitzgerald kafitzgerald approved these changes

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file testing Issue related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anissa111 @kafitzgerald