Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-pin ASV again and list env info #613

Merged
merged 3 commits into from
May 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/asv-benchmarking.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
jobs:
benchmark:
runs-on: ubuntu-latest
defaults:
run:
shell: bash -el {0}
env:
CONDA_ENV_FILE: ./build_envs/asv-bench.yml
ASV_DIR: ./benchmarks
Expand Down Expand Up @@ -39,7 +42,7 @@ jobs:
run: echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
shell: bash

- name: Cache Conda env
- name: Cache environment
uses: actions/cache@v4
with:
path: ${{ env.CONDA }}/envs
Expand All @@ -58,14 +61,18 @@ jobs:
./build_envs/asv-bench.yml
if: steps.cache.outputs.cache-hit != 'true'

- name: Conda list
run: |
conda info
conda list

- name: Copy existing results
run: |
if [ -d "geocat-comp-asv/results" ]; then
cp -r geocat-comp-asv/results benchmarks/
fi

- name: Run benchmarks
shell: bash -l {0}
id: benchmark
run: |
cd benchmarks
Expand Down
2 changes: 1 addition & 1 deletion build_envs/asv-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
- conda-forge
dependencies:
- python=3.10
- asv
- asv<0.6.2
- cf_xarray
- cftime
- cython
Expand Down
1 change: 1 addition & 0 deletions docs/release-notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Internal Changes
* Removed ``pre-commit.yaml`` action in favor of pre-commit.ci by `Cora Schneck`_ in (:pr:`608`)
* Remove ASV version pin and pin Conda version for benchmarking workflow by `Katelyn FitzGerald`_ in (:pr:`610`)
* Updates to issue and PR templates by `Anissa Zacharias`_ in (:pr:`612`)
* Re-pin ASV and list env info by `Katelyn FitzGerald`_ in (:pr:`613`)

v2024.04.0 (April 23, 2024)
---------------------------
Expand Down
Loading