CI: fixes and updates to pre-commit workflow for linting pass #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
added
testing
|
Oh, excellent - I was thinking it might be more complicated, hence the PR rather than lone commit(s) to address, but all that was needed was (my first guess) to update Trivial PR so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#283 shows that the linting workflow is running into numerous failures, mostly E231, which I don't see locally. This is to update the workflow and/or make fixes so we are up-to-date and can see only actual linting issues.
[WIP as I check the results of the CI jobs, since locally the linting passes for me so it us harder to isolate there what versions etc. are causing the (majority of the) error code violation raises.]