Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Learningpath folder form #2343

Merged
merged 21 commits into from
Feb 14, 2025
Merged

Learningpath folder form #2343

merged 21 commits into from
Feb 14, 2025
+396 −31

Conversation

MaPoKen
Copy link
Contributor

@MaPoKen MaPoKen commented Feb 11, 2025 •
edited
Loading

@MaPoKen MaPoKen force-pushed the learningpath-folder-form branch from aa9db9f to 53dd115 Compare February 11, 2025 13:54
@MaPoKen MaPoKen force-pushed the learningpath-folder-form branch from 53dd115 to f44ae4e Compare February 11, 2025 17:27
@MaPoKen MaPoKen marked this pull request as ready for review February 12, 2025 07:24
@MaPoKen MaPoKen requested a review from a team February 12, 2025 07:24
@katrinewi
Copy link
Contributor

katrinewi commented Feb 12, 2025 •
edited
Loading

Virker ikke som man kan velge ressurser i nestede mapper? 🤔

@katrinewi
Copy link
Contributor

Kanskje vi ikke trenger å vise den "Viser treff for"-teksten før man har søkt på noe?

@katrinewi
Copy link
Contributor

katrinewi commented Feb 12, 2025 •
edited
Loading

Syntes ikke navigering med tastatur i comboboksen fungerer så bra 😅 og man kan ikke selektere elementer med enter

katrinewi
katrinewi reviewed Feb 12, 2025
View reviewed changes
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderStepForm.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderStepForm.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderStepForm.tsx Outdated Show resolved Hide resolved
src/messages/messagesSE.ts Outdated Show resolved Hide resolved
@katrinewi
Copy link
Contributor

Hvis jeg lagrer et steg med artikkel fra en an mine mapper så settes radiobutton til "Innhold fra NDLA" etter lagring

@katrinewi
Copy link
Contributor

katrinewi commented Feb 12, 2025 •
edited
Loading

Burde fikse opp i visningen på mobil 😅
Skjermbilde 2025-02-12 kl 11 55 02

@katrinewi
Copy link
Contributor

Hvis man har en ressurs som finnes flere steder så dukker den opp en gang per posisjon i comboboksen, det er vel litt dumt? Hvis vi vil ha det sånn så må key settes på en annen måte, nå kan flere elementer ha samme key 😅

@katrinewi
Copy link
Contributor

Burde sette overflowWrap: "anywhere" på teksten som viser pathen til ressursen
Skjermbilde 2025-02-14 kl 09 05 33

@katrinewi
Copy link
Contributor

Hvis man fjerner en artikkel man allerede har lagret er lagring enabled
Skjermbilde 2025-02-14 kl 09 13 31

Jonas-C
Jonas-C reviewed Feb 14, 2025
View reviewed changes
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/ResourceStepForm.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated Show resolved Hide resolved
src/containers/MyNdla/Learningpath/components/FolderResourcePicker.tsx Outdated
.map((resource) => ({ ...resource, breadcrumb: folder.breadcrumbs })),
...flattenFolderResources(folder.subfolders),
])
.map((resource, index) => ({ ...resource, uniqueId: `${resource.id}-${index}` }));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvorfor trenger vi uniqueId?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi kan ha 2 like ressurser lagret i 2 forskjellige mapper, som gjør at vi må ha noe unikt å identifisere dem. Hedvig ville ha det

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvis ressurs finnes i flere mapper burde den vel strengt tatt bare dukke opp en gang, eller misforstår jeg noe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du kan ha flere mappe paths, som er litt av grunnen til at de vil vise begge 👯‍♂️

@MaPoKen MaPoKen requested a review from Jonas-C February 14, 2025 11:49
@Jonas-C Jonas-C force-pushed the learningpath-folder-form branch from b9b6e17 to 777f888 Compare February 14, 2025 14:53
@Jonas-C Jonas-C merged commit 563b293 into master Feb 14, 2025
6 checks passed
@Jonas-C Jonas-C deleted the learningpath-folder-form branch February 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarvelle gunnarvelle gunnarvelle left review comments

@katrinewi katrinewi katrinewi left review comments

@Jonas-C Jonas-C Awaiting requested review from Jonas-C

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaPoKen @katrinewi @gunnarvelle @Jonas-C