-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping of parameters that are common with CLM/E3SM #311
Comments
Hi @rosiealice - I agree that there should be some type of labeling as to which parameters are unique to FATES and which ones are host land model. I have needed to know these distinctions between the parameters from time to time (almost to the point where I am starting to learn most of them by heart.....crazy ;) ) It seems like the easiest is to just make a descriptive table in the wiki, and have users refer to this table. As we have seen the parameter file can change a lot, and updating this "offline" wiki table would probably be the most straightforward and lessen the chances for parameter file mistakes and errors. My two cents. |
Could FATES parameters be identifiable by name structure? E.g. all have the form |
Along the lines of what @bpbond is suggesting, I think we could do a combination of what has been suggested. We do currently prefix all fates parameters with a "fates_" namespace. So we could use the same parameter names after the fates_ prefix. We could also add an attribute to the parameters, like: "host_equivalent", which says "none" or gives the parameter name if its not unique to fates. |
Here's a first pass. I ncdumped fates and CLM parameter files, grepped for "double" to pull out the variable names, deleted the FATES_ prefix from the fates ones (@bpbond we do do what you are suggesting already, but some of them have a meaning in both models) and deleted the dimension info, then sorted and diffed them in emacs. Here are the shared params:
Here are the FATES params that don't have a match in the CLM file:
A couple of them differ only in name (e.g. BB slope), and some are in the CLM file but hard-coded (e.g. vcmaxse, etc...) |
That is the default right now, all parameters are denoted by "fates_xxx". It would mean going in and changing some to say, "hlm_fates_xxx" and those unique to FATES as just "fates_xxx". I guess it would not be that difficult. |
I quite like Ryan's 'host equivalent' metadata suggestion. We are already
using the naming convention to convey lots of different groupings. I think
adding others would be confusing.
…On Dec 22, 2017 1:18 PM, "Jennifer Holm" ***@***.***> wrote:
That is the default right now, all parameters are denoted by "fates_xxx".
It would mean going in and changing some to say, "hlm_fates_xxx" and those
unique to FATES as just "fates_xxx". I guess it would not be that difficult.
Then when new parameters come online, just keep this name structure. But
are there some that are overlap between both HLM and FATES? Maybe
fates_vcmax25top? I can't remember...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#311 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMWsQ3wDpty7yL3lRTOfVC3pYUvqZcxDks5tDA6qgaJpZM4RI_4V>
.
|
Closing per NGEET/fates-users-guide#11 |
@ran-feng, @jkshuman and I were just discussing how to make a parameter file for her miocene simulations that has a grass and an evergreen needleleaf tree. One useful thing here, we noted, would be a flag in the parameter file that could say whether a parameter was equivalent to one in the main model vs whether a parameter is unique to FATES. Then, one could know which parameters could be copied from the default file and which need to have new definitions.
Given there are probably quite a few people who will want to do this type of parameter file generation, it seems like this would be a useful addition.
On the other hand, it would put us in a position where we would need to track whether parameters had been deprecated by the host model.
Maybe another solution is just to have a table on the wiki or elsewhere which can give this information broadly to the user community who aren't as familiar with all of the history of these parameter fields.
What does everyone think? (tagging @aswann and @kovenock to see if this would be a thing you guys might enjoy)
The text was updated successfully, but these errors were encountered: