Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fates_turb_z0mr default parameter values #1319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glemieux
Copy link
Contributor

Description:

Addresses #1316

Collaborators:

@rosiealice

Expectation of Answer Changes: Yes

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@@ -15,45 +15,12 @@ dimensions:
fates_plant_organs = 4 ;
fates_string_length = 60 ;
variables:
double fates_history_ageclass_bin_edges(fates_history_age_bins) ;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgknox I'm seeing a lot of resorting of the names; should I fix this?

@glemieux glemieux requested a review from rosiealice February 4, 2025 22:04
@glemieux glemieux added the parameter file Pertaining to changes to the FATES parameter file label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parameter file Pertaining to changes to the FATES parameter file
Projects
Status: Under Review
Development

Successfully merging this pull request may close these issues.

1 participant