Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart fixes for two-stream #1321

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Jan 30, 2025

Description:

This set of changes, as well as changes to the host, enable restart tests to pass when two-stream radiation is active. Also, subtle updates were made to zenith angle handling, specifically zenith angle is passed at the site level and there is no need to pass in a zenith active flag. Some minor code clean up is also included.

Synchronize with CTSM #2949

Collaborators:

@ckoven

Expectation of Answer Changes:

This may change answers slightly, but should not have any meaningful science changes.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@rgknox rgknox added the draft label Jan 31, 2025
@rgknox
Copy link
Contributor Author

rgknox commented Feb 2, 2025

Note: this branch merged in luh2_nocomp_merge-bcindex from #1226

@glemieux
Copy link
Contributor

glemieux commented Feb 3, 2025

This should address ESCOMP/CTSM#2325, correct?

…fusion of ground albedos and performing a solve at the same time as constructing scattering elements
@rgknox
Copy link
Contributor Author

rgknox commented Feb 4, 2025

yes, I'll like the fix on the ctsm side of the PR

@rgknox rgknox removed the draft label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Finding Reviewers
Development

Successfully merging this pull request may close these issues.

2 participants