-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restart fixes for two-stream #1321
Open
rgknox
wants to merge
17
commits into
NGEET:main
Choose a base branch
from
rgknox:twostream-restart-fixes-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+383
−372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l value, this will be better for future implementations that have twilight or pre-dawn diffuse radiation scattering
Note: this branch merged in luh2_nocomp_merge-bcindex from #1226 |
This should address ESCOMP/CTSM#2325, correct? |
…fusion of ground albedos and performing a solve at the same time as constructing scattering elements
yes, I'll like the fix on the ctsm side of the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This set of changes, as well as changes to the host, enable restart tests to pass when two-stream radiation is active. Also, subtle updates were made to zenith angle handling, specifically zenith angle is passed at the site level and there is no need to pass in a zenith active flag. Some minor code clean up is also included.
Synchronize with CTSM #2949
Collaborators:
@ckoven
Expectation of Answer Changes:
This may change answers slightly, but should not have any meaningful science changes.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: