2025 Software Engineering meeting notes

Janurary 27, 2025

• Wins (1 min)
• Machine status and meeting notices (5 min)
• PR board status (10 min)
• Latest issues (5 min)
• Calibration update (10 min)

Wins and Whimsy 🎉

Machine status and notices 🖥️

• CISL: 11-12 February
• NERSC: 27-31 January, Full site power down

Upcoming meetings and events 🗓️

• FATES modeling meeting: TBD
  • FATES tool poll results
    • modify_params had highest uptake, batchpatch, consistent with Ryan's expectations
    • immediate take away: don't change anything, look
  • office hours: Greg to send out notice
• Mingjie and Jessie wind mortality meeting this Wednesday 11.30 - others welcome

PR board status update

Integrated

• Crown depth checks (#1314)
  • Marcos: should we add more alllometry checks?
    • Greg: definitely worthwhile to add more checks for user conveience.
      • One option would be to move convienence checks (i.e. not things that could crash the model) upstream to fates tooling that changes the parameter file.
  • Charlie: sapwood allometry?

Update

• Meier2022 fix (CTSM#2934): derecho testing looks good, waiting on izumi and ctsm5.3.021 tag completion
  • land use fixes (#1273), AllVars update (CTSM#2936), and use_fates_luh order (CTSM#2898) to be combined into #2934
• Grazing (#1140): Charlie update with PRT2 build fix. Greg retesting.
• nocomp patch refactor (#262): Needs review.

New

• nocomp patch refactor (#1315): Ryan to run 100-year smoke test to make sure things don't break

Latest issues and discussions of note

• z0mr parameters (#1316)
  • Adrianna is calibrating this, but consensus is that we should update them

Calibration progress update

• Jessica: ran CLM calibration parameter file in ELM. At preliminary review, it looks good.
• Adrianna: rerunning following htop issue fix (Adrianna to make formal issue).

Walk-on topic

• Charlie: land use spin up
  • Default decomp value in ELM is very agressive, Charlie adjusted and spin up works much better
  • Might be due to of the decomp method "scheme"
  • Default value in CLM is more reasonable relative to updated value
• Rosie: Meier2022
  • ELM
  • Ryan: making the code more "defensive"
    • Initializing fates code with "nan"
    • Don't allocate if not used
    • Adrianna: API that doesn't allow HLM to have access to data structures
    • Greg: look for API update issue/discussion

---

January 20, 2025

Canceled due to Federal Holiday

---

January 13, 2025

• Wins (1 min)
• Machine status and meeting notices (5 min)
• PR board status (10 min)
• Latest issues (5 min)
• Synthetic patches functional testing update (10 min) - deferred
• Calibration update (10 min)

Wins and Whimsy 🎉

• CTSM temp branch merged into master
• ctsm5.0.18 has history time being on the middle of time bounds
  • Marcos: will this be reflected in e3sm?
    • Greg will reach out to e3sm folks
• Rosie: New FATES post-doc hire. Will be working on dwarf shrub parameterization.

Machine status and notices 🖥️

• CISL: 11-12 February
• NERSC: 15 January

Upcoming meetings and events 🗓️

• FATES modeling meeting: 16 January, Annemarie Eckes-Shephard
  • Ryan to conduct informal poll on using patches.

PR board status update

Integrated

• e3sm API37 (E3SM#6762), ctsm hydro test update (CTSM#2882)

Update

• fates hydro solver param update (#1263): regression testing underway
  • Greg to create xml patch file
• veg temp weight fix (#1306): Needs a second reviewer
• leaf biophys refactor (#1262): Greg and Marcos reviewing
• Grazing: Greg to deconflict, ok to push directly per Charlie
  • Jennifer to quick review this as well.
  • Discussion about reasonableness of original values. Consider these highly uncertain for now. Bring these in with zero values now.
• nocomp patch cleanup: TL;DR, de-scoped a lot of changes. Mostly cleanup and "hardening" to make sure everything is consistent.
• use_fates_luh passing order (CTSM#2898): discussion about use_fates_potentialveg name change
• Large LAI crash fix (#1269): Ryan refactoring updates
• two-stream finidat fix (#1286): WIP, needs cleanup

New

• fix veg temp weighting (#1306): reviewed, Greg to test
• two-stream area adjustment calculation (#1310): WIP

Latest issues and discussions of note

• allom_h2cd check during read (#1308)

Synthetic patches for functional testing update (Adrianna)

• insert_cohort not preserving sorted order inherently - deferred

Calibration progress update

• deferred

Walk-on topic

• Rosie: https://github.com/ESCOMP/CTSM/issues/2932
  • Boundary conditions are different between clm6 and fates
  • Displacement height needs to be fixed, biasing SP results. Is Meier2022 the default? Check in with Adrianna.
  • Charlie: ELM using ZengWang? Rosie: yes
  • Ryan: create quick PR to make sure ZengWang is default if fates is on? Greg to address.
  • Jessie will reach out to Adrianna for latest parameter file and create a new smoke test

---

January 6, 2025

• Wins (1 min)
• Machine status and meeting notices (5 min)
• PR board status (10 min)
• Latest issues (5 min)
• Synthetic patches for functional testing
• Calibration update (10 min)

Wins and Whimsy 🎉

Machine status and notices 🖥️

• CISL: 11-12 February
• NERSC: 15 January

Upcoming meetings and events 🗓️

• FATES modeling meeting: 16 January, Annemarie Eckes-Shephard

PR board status update

Integrated

• modify_fates_paramfile fix (#1275), Indexing python tool fix (#1287), cmake functional test fix (#1303), ROS refactor (#1297), frac_burnt zero fix (#1302)

Update

• Land use fixes (#1273): Deconflicted and reviewed. Build test failing.
• e3sm API37 (E3SM#6762): Waiting on integration
• ctsm hydro test update (CTSM#2882): On hold due to izumi nag compiler test fails (CTSM#2924)

Latest issues and discussions of note

• FDI calculation (#1298)
  • Xuilin, NGEE-tropics phase 3 has a bunch of work planned (Lara)
  • Adrianna to bring this to the CA meeting
    • Jennifer will give Lara a heads up about discussing this at a future meeting
• fire calculations regardless of event (#1299)
  • Adrianna: do we want to avoid calculating values when there is no fire?
    • Sam: not doing so will improve computation. Maybe improve history output.
    • Sam: some of the fire outputs were weighted by burned area, but not all outputs.
    • Rosie: you might want to know the potential effects regardless of fire active or not (are you looking "upstream" or "downstream") .
• PVT run FAIL (CTSM#2919)

Synthetic (aka "dummy") patches for functional testing (Adrianna)

• Adrianna developing "dummy" patches for use with funtional and unit tests
• Idealized biomes with simplistic, well-defined values
• Motivated by future work to conduct with Danica as well as creating unit tests for cohort sorting, patch insertion, etc.

Calibration progress update

• no new updates due to break

Walk-on topic

• Rosie: NorESM working on repo to keep recipes for simulations being run. Maybe preview next week.

---