accept port ranges for ExposePorts config #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! Thanks for this merge request and the effort you've put in to make this. My only comment is that having the port range format using the dash ( I understand its written like this because iptables And one small comment is I'm away from computer for a bit so will test and merge when I get back. |
|
Understood will update it |
marulitua
force-pushed
the
expose_port_range
branch
from
89a6006 to
2b9a5f6
Compare
|
Hi @NHAS please check when you have time |
|
Yep will do now |
|
Sweet looks good and I've just merged it onto the unstable branch. Thanks for all your work! |
|
Awesome! Many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #66