[Feature/PI-320] Device created on and deleted on date #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslinnell
force-pushed
the
feature/PI-320-device_created_on_date
branch
from
516872f
to
b3bceeb
Compare
Rohoolio
reviewed
May 20, 2024
src/layers/domain/core/device.py
Outdated
| @@ -46,6 +51,9 @@ class DeviceUpdatedEvent(Event): | |||
| product_team_id: UUID | |||
| ods_code: str | |||
| status: "DeviceStatus" | |||
| created_on: str | |||
| updated_on: Optional[str] = None | |||
There was a problem hiding this comment.
Isnt a device updated event always going to have an updated_on date?
There was a problem hiding this comment.
Yes, good spot
jameslinnell
force-pushed
the
feature/PI-320-device_created_on_date
branch
from
b3bceeb
to
ae7e2c1
Compare
Rohoolio
approved these changes
May 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.