[feature/PI-592-gsi_upgrade] gsi upgrade #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaklinger
force-pushed
the
feature/PI-592-gsi_upgrade
branch
2 times, most recently
from
a0b7292
to
f0a3bea
Compare
megan-bower4
reviewed
Nov 8, 2024
| questionnaire_responses: dict[str, dict[str, "QuestionnaireResponse"]] | ||
|
|
||
|
|
||
| @dataclass(kw_only=True, slots=True) | ||
| class DeviceTagsClearedEvent(Event): | ||
| id: str | ||
| keys: list[dict] | ||
| deleted_tags: list["DeviceTag"] | ||
| deleted_tags: list[str] |
There was a problem hiding this comment.
Why aren't these DeviceTag's anymore?
There was a problem hiding this comment.
Good question... whilst doing this ticket I found that in half the Device*Events the tags field was a string and half was a DeviceTag, so I've standardised and corrected it. Makes sense for the event to see them as str as that's all the repo handler needs. I was thinking that could do the same with keys and DeviceKey, but it's a bit more complicated, so probs worth doing that in a separate tech debt ticket
megan-bower4
reviewed
Nov 8, 2024
megan-bower4
reviewed
Nov 8, 2024
src/layers/domain/repository/repository/tests/test_repository_v3.py
Outdated
Show resolved
Hide resolved
megan-bower4
reviewed
Nov 8, 2024
src/layers/domain/repository/repository/tests/test_repository_v3.py
Outdated
Show resolved
Hide resolved
jaklinger
force-pushed
the
feature/PI-592-gsi_upgrade
branch
from
f0a3bea
to
21f0ad3
Compare
megan-bower4
previously approved these changes
Nov 8, 2024
jaklinger
force-pushed
the
feature/PI-592-gsi_upgrade
branch
from
21f0ad3
to
86fffb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove items from this list if they are not relevant. Remove this line once this has been done
Details
Add any summary information of what is in the change. Remove this line if you have nothing to add.
Pull Request Naming
Pull requests should be named using the following format:
Tag can be one of:
Fix- for a bug fix. (Patch release)Update- either for a backwards-compatible enhancement or for a rule change that adds reported problems. (Patch release)New- implemented a new feature. (Minor release)Breaking- for a backwards-incompatible enhancement or feature. (Major release)Docs- changes to documentation only. (Patch release)Build- changes to build process only. (No release)Upgrade- for a dependency upgrade. (Patch release)Chore- for refactoring, adding tests, etc. (anything that isn't user-facing). (Patch release)If the current release is x.y.z then
Correct tagging is necessary for our automated versioning and release process.
The description of your pull request will be used as the commit message for the merge, and also be included in the changelog. Please ensure that your title is sufficiently descriptive.
Rerunning Checks
If you need to rename your pull request, you can restart the checks by either:
git commit --allow-empty -m 'trigger build' git pushRerunning the checks from within the pull request will not use the updated title.