Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/PI-617-split_ldif_by_party_key] split ldif by group #402

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jaklinger
Copy link
Contributor

Summary

Remove items from this list if they are not relevant. Remove this line once this has been done

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Details

Add any summary information of what is in the change. Remove this line if you have nothing to add.

Pull Request Naming

Pull requests should be named using the following format:

Tag: [AEA-NNNN] - Short description

Tag can be one of:

  • Fix - for a bug fix. (Patch release)
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems. (Patch release)
  • New - implemented a new feature. (Minor release)
  • Breaking - for a backwards-incompatible enhancement or feature. (Major release)
  • Docs - changes to documentation only. (Patch release)
  • Build - changes to build process only. (No release)
  • Upgrade - for a dependency upgrade. (Patch release)
  • Chore - for refactoring, adding tests, etc. (anything that isn't user-facing). (Patch release)

If the current release is x.y.z then

  • a patch release increases z by 1
  • a minor release increases y by 1
  • a major release increases x by 1

Correct tagging is necessary for our automated versioning and release process.

The description of your pull request will be used as the commit message for the merge, and also be included in the changelog. Please ensure that your title is sufficiently descriptive.

Rerunning Checks

If you need to rename your pull request, you can restart the checks by either:

  • Closing and reopening the pull request
  • pushing an empty commit
    git commit --allow-empty -m 'trigger build'
    git push
  • Amend your last commit and force push to the branch
    git commit --amend --no-edit
    git push --force

Rerunning the checks from within the pull request will not use the updated title.

@jaklinger jaklinger requested a review from a team as a code owner November 8, 2024 15:27
@megan-bower4 megan-bower4 force-pushed the feature/PI-617-split_ldif_by_party_key branch from 1f9b019 to 14fa4e5 Compare November 13, 2024 10:48
@jameslinnell jameslinnell merged commit 231d50c into main Nov 15, 2024
20 of 22 checks passed
@jameslinnell jameslinnell deleted the feature/PI-617-split_ldif_by_party_key branch November 15, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants