RELEASE/2023-11-24 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 24, 2023 16:33
Split out default_set Added comments and default_list Removed service level testing and reverted to references Tests passing Split references Split out reference Moved to using a Models class to generate pynamodb types Refactor Separated recursive to_dict and added tests Tests working converted to pydantic Fixed broken tests Moving to pydantic Added marshalling Removed pynamo Domain layer tests passing Got unit tests working Fixed tests Added ProductTeamRepository test Added ProductRepository test Separated keys Added more detail to Product repo tests Added keys/relationships to test Fixed on feature Fixed feature tests tidy upgraded moto removed debug Tweak named arguments over positional Added comments Added 'PRODUCT' type removed empty 'Field()' initialisers migraded to StrEnum Feedback Removed pynamo Added keys/relationships checks Restored file Consolidated errors branch naming Fixed tests Revert branch name linting Fixed int test
nomad3k
changed the title
jaklinger
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PI-124 - Revert Domain AR