Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: [AEA-4540] -update datetime for 1day prescriptions #2938

Merged

Conversation

jonathanwelch1-nhs
Copy link
Contributor

Summary

Medicus were trying to create / cancel 1 day prescriptions and found that if they specify the same end date as start date for a prescription (should be valid) then the FHIR validation considered it invalid. The recommendation to them was to specify 23:59:59 on the end date but the documentation could still lead other suppliers to the same issue.

  • Routine Change

Copy link
Contributor

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

AEA-4540

Copy link
Contributor

@MatthewPopat-NHS MatthewPopat-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the files in the examples folder.

format: date-time
example: "2022-10-21T23:59:59Z"
Must be in date-time format with the time set to 23:59:59 on the last valid day of the prescription, including for single-day prescriptions.
Example: "2022-10-21T23:59:59Z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think example: here needs a slight unindent?

@@ -156,8 +156,9 @@ properties:
description: |
End date of an issue; capped at 12 months and cannot exceed the prescription's end date.
Overall validity of the drug.
Must be in date-time format with the time set to 23:59:59 on the last valid day of the prescription, including for single-day prescriptions.
Example: "2022-10-21T23:59:59Z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think example: here needs a slight unindent?

@@ -153,8 +153,9 @@ properties:
description: |
End date of an issue; capped at 12 months and cannot exceed the prescription's end date.
Overall validity of the drug.
Must be in date-time format with the time set to 23:59:59 on the last valid day of the prescription, including for single-day prescriptions.
Example: "2022-10-21T23:59:59Z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think example: here needs a slight unindent?

seansteberisal
seansteberisal previously approved these changes Nov 14, 2024
Copy link

sonarcloud bot commented Nov 14, 2024

@MatthewPopat-NHS MatthewPopat-NHS enabled auto-merge (squash) November 14, 2024 14:45
@MatthewPopat-NHS MatthewPopat-NHS merged commit 1983dd8 into master Nov 14, 2024
16 of 17 checks passed
@MatthewPopat-NHS MatthewPopat-NHS deleted the aea-4540-update-datetime-for-1day-prescriptions branch November 14, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants