CCM-7650: review

NHSDigital · Nov 15, 2024 · b6310c1 · b6310c1
1 parent a8474cc
commit b6310c1
Show file tree

Hide file tree

Showing 3 changed files with 123 additions and 117 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/__tests__/components/Redirect.test.tsx b/src/__tests__/components/Redirect.test.tsx
@@ -16,17 +16,23 @@ jest.mock('next/navigation', () => ({
 const redirectMock = jest.mocked(redirect);
 const useSearchParamsMock = jest.mocked(useSearchParams);
 
-test.each(['/redirect-path', 'redirect-path'])('Redirect - URL provided %p', (redirect) => {
-  const mockSearchParams = new ReadonlyURLSearchParams({
-    redirect,
-  });
-
-  useSearchParamsMock.mockReturnValue(mockSearchParams);
-
-  render(<Redirect />);
-
-  expect(redirectMock).toHaveBeenCalledWith(`/redirect/redirect-path`, 'push');
-});
+test.each(['/redirect-path', 'redirect-path'])(
+  'Redirect - URL provided %p',
+  (testPath) => {
+    const mockSearchParams = new ReadonlyURLSearchParams({
+      testPath,
+    });
+
+    useSearchParamsMock.mockReturnValue(mockSearchParams);
+
+    render(<Redirect />);
+
+    expect(redirectMock).toHaveBeenCalledWith(
+      `/redirect/redirect-path`,
+      'push'
+    );
+  }
+);
 
 test('Redirect - URL not provided', () => {
   const mockSearchParams = new ReadonlyURLSearchParams({});

diff --git a/src/components/molecules/Redirect/Redirect.tsx b/src/components/molecules/Redirect/Redirect.tsx
@@ -1,7 +1,7 @@
 'use client';
 
 import { useSearchParams, redirect, RedirectType } from 'next/navigation';
-import path from 'path';
+import path from 'node:path';
 
 export const Redirect = () => {
   const searchParams = useSearchParams();