Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-5850: Review code owners #12

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

m-salaudeen
Copy link
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@m-salaudeen m-salaudeen self-assigned this Jul 31, 2024
@mark-r-bjss
Copy link

We should be following the pattern that has been established in the template management repo: https://github.com/NHSDigital/nhs-notify-web-template-management/blob/main/.github/CODEOWNERS

The equivalent teams are:
https://github.com/orgs/NHSDigital/teams/nhs-notify-iam-webauth
https://github.com/orgs/NHSDigital/teams/nhs-notify-iam-webauth-testers

project.code-workspace Outdated Show resolved Hide resolved
mark-r-bjss
mark-r-bjss previously approved these changes Jul 31, 2024
Base automatically changed from feature/CCM-5849_Accessibility to main July 31, 2024 14:13
@m-salaudeen m-salaudeen dismissed mark-r-bjss’s stale review July 31, 2024 14:13

The base branch was changed.

mark-r-bjss
mark-r-bjss previously approved these changes Jul 31, 2024
@m-salaudeen m-salaudeen merged commit eb1e8fc into main Aug 1, 2024
27 checks passed
@m-salaudeen m-salaudeen deleted the feature/CCM-5850_Review_code_owners branch August 1, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants