Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-5680 Support dedicated dev env branches #18

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

aidenvaines-bjss
Copy link
Contributor

Description

the reliance on the acct component didnt play well with the changes for the iam component being more flexible. Swap the acct lookup for an output from IAM component rather than having to declare multiple state lookups

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@aidenvaines-bjss aidenvaines-bjss requested a review from a team as a code owner August 5, 2024 10:16
@aidenvaines-bjss aidenvaines-bjss merged commit 4f627ff into main Aug 5, 2024
27 checks passed
@aidenvaines-bjss aidenvaines-bjss deleted the CCM-5680_SupportDedicatedDevEnvBranchFix branch August 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants