Merge pull request #150 from NHSDigital/feature/eema1-NRL-767-skipPer…

…missionsCheckForSync Feature/eema1 nrl 767 skip permissions check for sync
NHSDigital · Jun 14, 2024 · 1e5fd51 · 1e5fd51
2 parents b442aa0 + 718da0f
commit 1e5fd51
Showing 1 changed file with 26 additions and 23 deletions.
diff --git a/proxies/live/apiproxy/resources/jsc/ConnectionMetadata.SetRequestHeaders.js b/proxies/live/apiproxy/resources/jsc/ConnectionMetadata.SetRequestHeaders.js
@@ -30,39 +30,55 @@
     return;
   }
 
-  var enableAuthorizationLookup = context.getVariable("app.enable-authorization-lookup");
+  var nrlPermissions = context.getVariable("app.nrl-permissions");
+  var hasAllPointerPermissions = false;
 
+  if (nrlPermissions != null) {
+    // Convert it into a complex object
+    var permissionLines = nrlPermissions.split(/\s+/);
+    var permissions = [];
+    for (var i = 0; i < permissionLines.length; i++) {
+      var permissionLine = permissionLines[i];
+      if (permissionLine && permissionLine.trim().length !== 0) {
+        permissions.push(permissionLine);
+      }
+    }
+    if (nrlPermissions.includes("allow-all-pointer-types") === true) {
+      hasAllPointerPermissions = true;
+    }
+    nrlPermissions = permissions;
+  }
+
+  var enableAuthorizationLookup = context.getVariable("app.enable-authorization-lookup");
   if(enableAuthorizationLookup == "true") {
     enableAuthorizationLookup = true
-  } else if (enableAuthorizationLookup === null) {
+  } else if (enableAuthorizationLookup === null  || enableAuthorizationLookup == "false") {
     enableAuthorizationLookup = false
   } else {
     //This will trigger RaiseFault.403NoPointers.xml - see targets/target.xml
     return;
   }
 
-
   var pointerTypes = [];
   // Read the associated `nrl-ods-<ods_code>` custom attribute from the APIGEE app
   var nrlPointerTypes = context.getVariable("app.nrl-ods-" + odsCode);
 
-  if ((enableAuthorizationLookup === true && nrlPointerTypes) || (enableAuthorizationLookup === false && !nrlPointerTypes)) {
-    //This will trigger RaiseFault.403NoPointers.xml - see targets/target.xml
-    return;
+  if (!hasAllPointerPermissions && (!enableAuthorizationLookup && !nrlPointerTypes)) {
+   //This will trigger RaiseFault.403NoPointers.xml - see targets/target.xml
+   return;
   }
 
   if (nrlPointerTypes){
     // Convert it into a complex object
     var lines = nrlPointerTypes.split(/\s+/);
-  
+
     for (var i = 0; i < lines.length; i++) {
       var line = lines[i];
       if (line && line.trim().length !== 0) {
         pointerTypes.push(line);
       }
     }
-  } 
-
+  }
 
   var odsCodeExtension = context.getVariable(
     "request.header.NHSD-End-User-Organisation"
@@ -75,21 +91,8 @@
     "nrl.pointer-types": pointerTypes,
     "nrl.enable-authorization-lookup": enableAuthorizationLookup
   };
-
-  var nrlPermissions = context.getVariable("app.nrl-permissions");
-
   if (nrlPermissions != null) {
-    // Convert it into a complex object
-    var permissionLines = nrlPermissions.split(/\s+/);
-    var permissions = [];
-    for (var i = 0; i < permissionLines.length; i++) {
-      var permissionLine = permissionLines[i];
-      if (permissionLine && permissionLine.trim().length !== 0) {
-        permissions.push(permissionLine);
-      }
-    }
-
-    connectionMetadata["nrl.permissions"] = permissions;
+    connectionMetadata["nrl.permissions"] = nrlPermissions;
   }
 
   context.targetRequest.headers["NHSD-Connection-Metadata"] =