Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NRLF-582] Add CORS headers to catchAll Error response #117

Merged
merged 8 commits into from
Sep 14, 2023
Merged

[NRLF-582] Add CORS headers to catchAll Error response #117

merged 8 commits into from
Sep 14, 2023

Conversation

jameslinnell
Copy link
Contributor

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@jameslinnell jameslinnell changed the title Add CORS headers to catchAll Error response [NRLF-582] Add CORS headers to catchAll Error response Aug 22, 2023
axelkrastek1-nhs
axelkrastek1-nhs approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@axelkrastek1-nhs axelkrastek1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@axelkrastek1-nhs axelkrastek1-nhs force-pushed the feature/NRLF-582_CORS_issues_in_TRY_section branch from f13fb1b to 04809f1 Compare September 6, 2023 09:59
@axelkrastek1-nhs axelkrastek1-nhs merged commit cde3b49 into master Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelkrastek1-nhs axelkrastek1-nhs axelkrastek1-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslinnell @axelkrastek1-nhs