Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/eema1 nrl 767 skip permissions check for sync #150

Merged
merged 15 commits into from
Jun 14, 2024
Merged

Feature/eema1 nrl 767 skip permissions check for sync #150

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
28b0442
check nrl permissions for allow all permission
eesa456 Jun 11, 2024
0127be3
update comment
eesa456 Jun 11, 2024
59f8d43
update check
eesa456 Jun 11, 2024
19220ad
move ods code check
eesa456 Jun 11, 2024
c9e6e9b
testing message
eesa456 Jun 11, 2024
bec9307
update message test
eesa456 Jun 11, 2024
6d0ca73
revert
eesa456 Jun 11, 2024
acb3e9b
NRL-767 clean up function
eesa456 Jun 12, 2024
5219217
check for all pointr permissions in attribute
eesa456 Jun 12, 2024
a6d1863
Merge branch 'feature/eema1-NRL-767-skipPermissionsCheckForSync' of g…
eesa456 Jun 13, 2024
7465032
update check to find permission
eesa456 Jun 13, 2024
cbba836
only add header if permissions
eesa456 Jun 13, 2024
dfda9d6
check nrl permissions instead if permissions doesnt exist
eesa456 Jun 14, 2024
e724b07
use null check over length
eesa456 Jun 14, 2024
718da0f
remove bug for both lookup and ods attribuet enabled
eesa456 Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 26 additions & 23 deletions proxies/live/apiproxy/resources/jsc/ConnectionMetadata.SetRequestHeaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,39 +30,55 @@
return;
}

var enableAuthorizationLookup = context.getVariable("app.enable-authorization-lookup");
var nrlPermissions = context.getVariable("app.nrl-permissions");
var hasAllPointerPermissions = false;

if (nrlPermissions != null) {
// Convert it into a complex object
var permissionLines = nrlPermissions.split(/\s+/);
var permissions = [];
for (var i = 0; i < permissionLines.length; i++) {
var permissionLine = permissionLines[i];
if (permissionLine && permissionLine.trim().length !== 0) {
permissions.push(permissionLine);
}
}
if (nrlPermissions.includes("allow-all-pointer-types") === true) {
hasAllPointerPermissions = true;
}
nrlPermissions = permissions;
}

var enableAuthorizationLookup = context.getVariable("app.enable-authorization-lookup");
if(enableAuthorizationLookup == "true") {
enableAuthorizationLookup = true
} else if (enableAuthorizationLookup === null) {
} else if (enableAuthorizationLookup === null || enableAuthorizationLookup == "false") {
axelkrastek1-nhs marked this conversation as resolved.
Show resolved Hide resolved
enableAuthorizationLookup = false
} else {
//This will trigger RaiseFault.403NoPointers.xml - see targets/target.xml
return;
}


var pointerTypes = [];
// Read the associated `nrl-ods-<ods_code>` custom attribute from the APIGEE app
var nrlPointerTypes = context.getVariable("app.nrl-ods-" + odsCode);

if ((enableAuthorizationLookup === true && nrlPointerTypes) || (enableAuthorizationLookup === false && !nrlPointerTypes)) {
//This will trigger RaiseFault.403NoPointers.xml - see targets/target.xml
return;
if (!hasAllPointerPermissions && (!enableAuthorizationLookup && !nrlPointerTypes)) {
//This will trigger RaiseFault.403NoPointers.xml - see targets/target.xml
return;
}

if (nrlPointerTypes){
// Convert it into a complex object
var lines = nrlPointerTypes.split(/\s+/);

for (var i = 0; i < lines.length; i++) {
var line = lines[i];
if (line && line.trim().length !== 0) {
pointerTypes.push(line);
}
}
}

}

var odsCodeExtension = context.getVariable(
"request.header.NHSD-End-User-Organisation"
Expand All @@ -75,21 +91,8 @@
"nrl.pointer-types": pointerTypes,
"nrl.enable-authorization-lookup": enableAuthorizationLookup
};

var nrlPermissions = context.getVariable("app.nrl-permissions");

if (nrlPermissions != null) {
// Convert it into a complex object
var permissionLines = nrlPermissions.split(/\s+/);
var permissions = [];
for (var i = 0; i < permissionLines.length; i++) {
var permissionLine = permissionLines[i];
if (permissionLine && permissionLine.trim().length !== 0) {
permissions.push(permissionLine);
}
}

connectionMetadata["nrl.permissions"] = permissions;
connectionMetadata["nrl.permissions"] = nrlPermissions;
}

context.targetRequest.headers["NHSD-Connection-Metadata"] =
Expand Down
Loading