Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPA-1711: API Update #48

Merged
merged 7 commits into from
Apr 11, 2024

Conversation

chris-young-12-nhs
Copy link
Contributor

@chris-young-12-nhs chris-young-12-nhs commented Apr 10, 2024

Summary

  • ❗ Breaking Change

  • Changes structure of RelatedPerson component to match Patient component stucture.

  • Updates description to meet APIM requirements

  • Specifies identifier and patientIdentifier parameters to have format of token

  • Specifies format of Correlation ID

  • Changes 200 response descriptions

  • Adds Additional FHIR attributes to FHIR components

  • Set placeholder version number

  • Added instructions for Sandbox Test Scenarios

  • Added detail to FHIR bundle link array attribute description

Reviews Required

  • Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-1711

Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-1711

JackPlowman
JackPlowman previously approved these changes Apr 11, 2024
Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-1711

Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-1711

Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chris-young-12-nhs chris-young-12-nhs merged commit 15724e5 into master Apr 11, 2024
9 checks passed
@chris-young-12-nhs chris-young-12-nhs deleted the dev/NPA-1711_add_format_to_search_params branch April 11, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants