Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPA-2500 Fix Sandbox Full URL #56

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

JackPlowman
Copy link
Contributor

@JackPlowman JackPlowman commented Apr 26, 2024

Summary

  • Routine Change

Description

  • Hardcode Sandbox Full URL to use sandbox instead of internal-dev
  • Bump Python/Node versions to hopefully fix some security alerts

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2500

Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2500

sandbox/api/app.py Fixed Show fixed Hide fixed
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2500

@JackPlowman JackPlowman changed the title NPA-2500 Fix Sandbox full URL NPA-2500 Fix Sandbox Full URL Apr 26, 2024
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2500

@JackPlowman JackPlowman marked this pull request as ready for review April 26, 2024 14:25
Copy link
Contributor

@chris-young-12-nhs chris-young-12-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris-young-12-nhs chris-young-12-nhs merged commit 6aef934 into master Apr 26, 2024
9 checks passed
@JackPlowman JackPlowman deleted the NPA-2500_Incorrect_Sandbox_Response branch April 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants