Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPA-2676: Receive QuestionnaireResponse #78

Merged
merged 8 commits into from
May 16, 2024
Merged

NPA-2676: Receive QuestionnaireResponse #78

merged 8 commits into from
May 16, 2024

Conversation

chris-young-12-nhs
Copy link
Contributor

Summary

  • ✨ New Feature - first cut POST QuestionnaireResponse endpoint

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2676

@chris-young-12-nhs chris-young-12-nhs changed the title Npa 2676 receive questionnaire NPA-2676: Receive QuestionnaireResponse May 16, 2024
@chris-young-12-nhs chris-young-12-nhs self-assigned this May 16, 2024
JackPlowman
JackPlowman requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of questions/formatting suggestions

specification/validated-relationships-service-api.yaml Show resolved Hide resolved
specification/validated-relationships-service-api.yaml Show resolved Hide resolved
specification/validated-relationships-service-api.yaml Show resolved Hide resolved
specification/validated-relationships-service-api.yaml Show resolved Hide resolved
specification/validated-relationships-service-api.yaml Show resolved Hide resolved
specification/validated-relationships-service-api.yaml Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2676

@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2676

JackPlowman
JackPlowman approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2676

@chris-young-12-nhs chris-young-12-nhs merged commit 0361a51 into master May 16, 2024
9 checks passed
@chris-young-12-nhs chris-young-12-nhs deleted the NPA-2676-receive-questionnaire branch May 16, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackPlowman JackPlowman JackPlowman approved these changes

Assignees

@chris-young-12-nhs chris-young-12-nhs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-young-12-nhs @JackPlowman