Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPA-2806 Support application/fhir+json; charset=utf-8 Content Type #90

Merged
merged 3 commits into from
Jun 28, 2024
Merged

NPA-2806 Support application/fhir+json; charset=utf-8 Content Type #90

merged 3 commits into from
Jun 28, 2024

Conversation

JackPlowman
Copy link
Contributor

@JackPlowman JackPlowman commented Jun 28, 2024 •
edited
Loading

Pull Request Checklist

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-2806

Description/Change Summary

  • Add support for content type - application/fhir+json; charset=utf-8

How to test?

  • Deployed to the dev API and manually tested

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@JackPlowman JackPlowman force-pushed the NPA-2806_Fix_Mime_Response_Type branch from c378e5f to 48f22f5 Compare June 28, 2024 11:57
@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2806

1 similar comment
@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2806

@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2806

@JackPlowman JackPlowman self-assigned this Jun 28, 2024
@JackPlowman JackPlowman added the enhancement New feature or request label Jun 28, 2024
@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2806

@JackPlowman JackPlowman marked this pull request as ready for review June 28, 2024 13:16
@JackPlowman JackPlowman changed the title NPA-2806 NPA-2806 Support application/fhir+json; charset=utf-8 content type Jun 28, 2024
@JackPlowman JackPlowman changed the title NPA-2806 Support application/fhir+json; charset=utf-8 content type NPA-2806 Support application/fhir+json; charset=utf-8 Content Type Jun 28, 2024
joanne-doyle7-NHSD
joanne-doyle7-NHSD approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@joanne-doyle7-NHSD joanne-doyle7-NHSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs a test in the API tests in the proxy validated relationship service repo to show that the application/fhir+json; charset=utf-8 case is covered. Separate PR would be needed.

chris-young-12-nhs
chris-young-12-nhs approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@chris-young-12-nhs chris-young-12-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackPlowman JackPlowman merged commit cf994c2 into master Jun 28, 2024
9 checks passed
@JackPlowman JackPlowman deleted the NPA-2806_Fix_Mime_Response_Type branch June 28, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanne-doyle7-NHSD joanne-doyle7-NHSD joanne-doyle7-NHSD approved these changes

@chris-young-12-nhs chris-young-12-nhs chris-young-12-nhs approved these changes

Assignees

@JackPlowman JackPlowman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackPlowman @chris-young-12-nhs @joanne-doyle7-NHSD