Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPA-2806 Fix incorrect Content-Type Condition #91

Merged
merged 2 commits into from
Jul 1, 2024
Merged

NPA-2806 Fix incorrect Content-Type Condition #91

merged 2 commits into from
Jul 1, 2024

Conversation

JackPlowman
Copy link
Contributor

@JackPlowman JackPlowman commented Jun 28, 2024 •
edited
Loading

Pull Request Checklist

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-2806

Description/Change Summary

-Fixes incorrect content type condition

How to test?

  • Modified the dev API and then ran phase_two tests to prove it works

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@JackPlowman JackPlowman added the bug Something isn't working label Jun 28, 2024
@JackPlowman JackPlowman self-assigned this Jun 28, 2024
@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2806

@JackPlowman JackPlowman marked this pull request as ready for review July 1, 2024 07:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-2806

chris-young-12-nhs
chris-young-12-nhs approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@chris-young-12-nhs chris-young-12-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry I didn't spot this first time around.

@chris-young-12-nhs chris-young-12-nhs merged commit 8a55874 into master Jul 1, 2024
9 checks passed
@JackPlowman JackPlowman deleted the NPA-2806_Fix_Incorrect_Content_Type_Condition branch July 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-young-12-nhs chris-young-12-nhs chris-young-12-nhs approved these changes

Assignees

@JackPlowman JackPlowman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackPlowman @chris-young-12-nhs