NPA-3181: update post questionnaire oas

[Stoods-hd]

Pull Request Checklist

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-3181

Description/Change Summary

Updated the OAS spec to reflect the new data dictionary and FHIR specification

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• I have ensured the changelog has been updated by the submitter, if necessary.

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3181

[JackPlowman]

Looks good. I've got a couple of comments I would like to be answered. But happy to approve if necessary.

[miiisterjim]

Looks good. Some cosmetic bits n bobs

One standout thing, I THINK oneOf only enforces the shape of objects and that there is no more than one, it doesn't enforce "requiredness". So I think we need a smattering of required's adding throughout. In particular questionnaire, subject and source (whilst not mandated in the QuestionnaireResponse schema, we need them, so should be mandating those and others for our own context). Unless we intend to set authored and status server-side, then these will need to be mandated too (perhaps it does make more sense to set those two server-side, but that needs capturing in a ticket somewhere obvs if not already)

[chris-young-12-nhs]

Have responded to other reviewers questions. Think these need to be resolved before this is good to go. Also as per @JackPlowman's comment. We want to hold off merging until we have updated the tests to work with the new spec.

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3181

All comments actioned

[miiisterjim]

Some tweaks please. I'd suggest raising tickets (or ensuring we have explicit acceptance criteria) to capture the conditional mandatory demographics for patient & proxy

Thanks!

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3181

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3181

All suggested changes made

[chris-young-12-nhs]

LGTM based on @JackPlowman & @miiisterjim's feedback and actions from @Stoods-hd

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3181

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3181

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3181

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3181

[chris-young-12-nhs]

Tests passing for VRS when pointing to the spec here:

https://github.com/NHSDigital/proxy-validated-relationships-service/actions/runs/10094660128/job/27915932060