Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

214 add extra company information #303

Closed
wants to merge 10 commits into from

Conversation

CiscoPr
Copy link

@CiscoPr CiscoPr commented Feb 7, 2023

8 tests are failing but the main code is done. Needs some reviews to discover where the errors are.

@CiscoPr CiscoPr linked an issue Feb 7, 2023 that may be closed by this pull request
@render
Copy link

render bot commented Feb 7, 2023

src/api/middleware/files.js Outdated Show resolved Hide resolved
Copy link
Member

@diogofonte diogofonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and the tests implemented seem good to me, but the support for adding several locations is available? I didn't notice it in the files changes. I'm asking this because of this comment: #214 (comment)

@CiscoPr
Copy link
Author

CiscoPr commented Feb 9, 2023

The code and the tests implemented seem good to me, but the support for adding several locations is available? I didn't notice it in the files changes. I'm asking this because of this comment: #214 (comment)

yes i forgot to add that, thanks for reminding me.
@Naapperas, these several locations are also an optional company field or does it must have a minimal length?

@DoStini
Copy link
Member

DoStini commented Feb 12, 2023

Just a note: commits should try to be small. On a more important note, commits should explain what it does or what it solves, and not the state of the issue.

We also standardized using rebase instead of merge (from develop), if need help in this reach us

@CiscoPr CiscoPr force-pushed the 214-add-extra-company-information branch from b0c27ee to ce29dd7 Compare February 28, 2023 16:26
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 11.36% and project coverage change: -2.64% ⚠️

Comparison is base (f698ee0) 90.33% compared to head (197cbdd) 87.69%.
Report is 1 commits behind head on develop.

❗ Current head 197cbdd differs from pull request most recent head 54e5970. Consider uploading reports for the commit 54e5970 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
- Coverage    90.33%   87.69%   -2.64%     
===========================================
  Files           54       54              
  Lines         1469     1447      -22     
  Branches       245      234      -11     
===========================================
- Hits          1327     1269      -58     
- Misses         137      167      +30     
- Partials         5       11       +6     
Files Changed Coverage Δ
src/api/middleware/validators/company.js 100.00% <ø> (ø)
src/models/Company.js 100.00% <ø> (ø)
src/api/middleware/files.js 42.68% <7.14%> (-38.27%) ⬇️
src/api/routes/company.js 87.34% <100.00%> (-1.32%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/services/company.js Fixed Show fixed Hide fixed
src/api/middleware/files.js Fixed Show fixed Hide fixed
@CiscoPr CiscoPr force-pushed the 214-add-extra-company-information branch 2 times, most recently from 84b00a3 to e547b09 Compare May 23, 2023 11:02
@CiscoPr CiscoPr force-pushed the 214-add-extra-company-information branch from e547b09 to 6e7d240 Compare May 23, 2023 11:08
const logo = req?.file?.url || `${config.webserver_host}/static/${req.file.filename}`;
const images = req?.files?.map((file) => file?.url || `${config.webserver_host}/static/${file.filename}`) ?? [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be a function: should we need this logic elsewhere we only need to change it in one place.

@CiscoPr CiscoPr closed this Mar 6, 2024
@Naapperas
Copy link
Member

@CiscoPr What happened?

@CiscoPr
Copy link
Author

CiscoPr commented Mar 14, 2024

@Naapperas i just created another branch for this issue and I will open another PR with it. I wanted to start it over again to be less confusing since this one was really outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants