-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
214 add extra company information #303
Conversation
Your Render PR Server URL is https://nijobs-be-pr-303.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cfh7kao2i3mkm5uh5ke0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code and the tests implemented seem good to me, but the support for adding several locations is available? I didn't notice it in the files changes. I'm asking this because of this comment: #214 (comment)
yes i forgot to add that, thanks for reminding me. |
Just a note: commits should try to be small. On a more important note, commits should explain what it does or what it solves, and not the state of the issue. We also standardized using rebase instead of merge (from develop), if need help in this reach us |
b0c27ee
to
ce29dd7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #303 +/- ##
===========================================
- Coverage 90.33% 87.69% -2.64%
===========================================
Files 54 54
Lines 1469 1447 -22
Branches 245 234 -11
===========================================
- Hits 1327 1269 -58
- Misses 137 167 +30
- Partials 5 11 +6
☔ View full report in Codecov by Sentry. |
84b00a3
to
e547b09
Compare
e547b09
to
6e7d240
Compare
const logo = req?.file?.url || `${config.webserver_host}/static/${req.file.filename}`; | ||
const images = req?.files?.map((file) => file?.url || `${config.webserver_host}/static/${file.filename}`) ?? []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should be a function: should we need this logic elsewhere we only need to change it in one place.
@CiscoPr What happened? |
@Naapperas i just created another branch for this issue and I will open another PR with it. I wanted to start it over again to be less confusing since this one was really outdated |
8 tests are failing but the main code is done. Needs some reviews to discover where the errors are.