Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #311

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

Refactor tests #311

wants to merge 30 commits into from

Conversation

Naapperas
Copy link
Member

@Naapperas Naapperas commented Mar 1, 2023

Closes #169

This attempts to fix and "normalize" the many tests we have on NIJobs in order to make them more manageable.

@render
Copy link

render bot commented Mar 1, 2023

@Naapperas Naapperas changed the title Refactored auth tests Refactor tests Mar 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f698ee0) 90.33% compared to head (f23a0e1) 90.45%.
Report is 1 commits behind head on develop.

❗ Current head f23a0e1 differs from pull request most recent head 5bd79a6. Consider uploading reports for the commit 5bd79a6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
+ Coverage    90.33%   90.45%   +0.12%     
===========================================
  Files           54       54              
  Lines         1469     1477       +8     
  Branches       245      245              
===========================================
+ Hits          1327     1336       +9     
+ Misses         137      136       -1     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Naapperas Naapperas force-pushed the fix/fix-tests branch 2 times, most recently from 65c93ea to c2a11e5 Compare March 28, 2023 16:46
@Naapperas
Copy link
Member Author

After refactoring work on this PR is finished, I am going to write documentation regarding how contributors should write tests.

@Naapperas Naapperas force-pushed the fix/fix-tests branch 2 times, most recently from 290bc05 to 08a3ecc Compare April 25, 2023 21:44
@Naapperas Naapperas self-assigned this Apr 27, 2023
@Naapperas
Copy link
Member Author

Looks like we will still need to wait for a new version of fast-xml-parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Normalize" tests
2 participants