-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #311
base: develop
Are you sure you want to change the base?
Refactor tests #311
Conversation
Your Render PR Server URL is https://nijobs-backend-pr-311.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cfvt1se4dad04sqe6730. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #311 +/- ##
===========================================
+ Coverage 90.33% 90.45% +0.12%
===========================================
Files 54 54
Lines 1469 1477 +8
Branches 245 245
===========================================
+ Hits 1327 1336 +9
+ Misses 137 136 -1
Partials 5 5 ☔ View full report in Codecov by Sentry. |
65c93ea
to
c2a11e5
Compare
After refactoring work on this PR is finished, I am going to write documentation regarding how contributors should write tests. |
290bc05
to
08a3ecc
Compare
Looks like we will still need to wait for a new version of |
Closes #169
This attempts to fix and "normalize" the many tests we have on NIJobs in order to make them more manageable.