Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup eslint #307

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Setup eslint #307

merged 4 commits into from
Sep 20, 2024

Conversation

tomaspalma
Copy link
Member

@tomaspalma tomaspalma commented Sep 16, 2024

This setups eslint and a github action to run the linter

@tomaspalma tomaspalma self-assigned this Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for tts-fe-preview ready!

Name Link
🔨 Latest commit b019db0
🔍 Latest deploy log https://app.netlify.com/sites/tts-fe-preview/deploys/66ec946be68a990008b96c52
😎 Deploy Preview https://deploy-preview-307--tts-fe-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomaspalma tomaspalma force-pushed the chore/linter branch 2 times, most recently from c605061 to ea538da Compare September 16, 2024 12:51
@tomaspalma tomaspalma changed the title Chore/linter Setup eslint Sep 16, 2024
@tomaspalma tomaspalma force-pushed the chore/linter branch 2 times, most recently from 191757a to 3b89f52 Compare September 16, 2024 12:57
@tomaspalma tomaspalma requested a review from a team September 16, 2024 13:01
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why some many eslint-enable ? 🙄

package.json Show resolved Hide resolved
src/components/ui/use-toast.ts Outdated Show resolved Hide resolved
eslint.config.js Show resolved Hide resolved
@tomaspalma tomaspalma force-pushed the chore/linter branch 3 times, most recently from 0155ca1 to e314df7 Compare September 17, 2024 20:04
@tomaspalma tomaspalma requested a review from a team September 18, 2024 12:13
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the action only run on ready PRs and ignore on drafts? To save some time :)

https://stackoverflow.com/questions/68349031/only-run-actions-on-non-draft-pull-request

@tomaspalma
Copy link
Member Author

Can we make the action only run on ready PRs and ignore on drafts? To save some time?

That is a good idea, will do that!

@tomaspalma tomaspalma marked this pull request as draft September 19, 2024 21:09
@tomaspalma tomaspalma marked this pull request as draft September 19, 2024 21:09
@tomaspalma tomaspalma marked this pull request as ready for review September 19, 2024 21:10
@tomaspalma
Copy link
Member Author

@thePeras Done!

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go!

@tomaspalma tomaspalma merged commit 8db09ed into develop Sep 20, 2024
5 checks passed
@tomaspalma tomaspalma deleted the chore/linter branch September 20, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants