fix: class selection now always sets the correct class on the schedule #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tomaspalma
force-pushed
the
fix/class-preview-sometimes-wrong
branch
from
97cb10a
to
b6f32e1
Compare
Wallen-Ribeiro
approved these changes
Oct 1, 2024
tomaspalma
force-pushed
the
fix/class-preview-sometimes-wrong
branch
from
b6f32e1
to
5951cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #300
Apparently the
Dropdowncomponent we are using acts in weird ways.Even though the dropdown was closed, for some reason, during a small amount of time, the
<ClassItem>s that have theonMouseEnterare activated, even though they are no longer visible.The fix was putting an
ifstatement inside theonMouseEnterevent listener function so that the preview is only added when the dropdown is actually open.