Refactor feature flag dialog

packages/uni_app/lib/controller/feature_flags/feature_flag_controller.dart

@@ -12,7 +12,7 @@ class FeatureFlagController {
     return preferences.getBool(_getKey(code)) ?? false;
   }
 
-  void saveEnabled(String code, {required bool enabled}) {
-    preferences.setBool(_getKey(code), enabled);
+  Future<void> saveEnabled(String code, {required bool enabled}) {
+    return preferences.setBool(_getKey(code), enabled);
   }
 }

packages/uni_app/lib/controller/feature_flags/feature_flag_table.dart

@@ -20,7 +20,8 @@ class FeatureFlagTable {
   static FeatureFlagController? _controller;
 
   static List<GenericFeatureFlag> _toFeatureFlags(
-      List<GenericFeatureFlagInfo> featureFlagInfos) {
+    List<GenericFeatureFlagInfo> featureFlagInfos,
+  ) {
     final featureFlags = <GenericFeatureFlag>[];
 
     for (final featureFlagInfo in featureFlagInfos) {
@@ -35,7 +36,8 @@ class FeatureFlagTable {
   }
 
   static Map<String, GenericFeatureFlag> _toFeatureFlagsMap(
-      List<GenericFeatureFlag> featureFlags) {
+    List<GenericFeatureFlag> featureFlags,
+  ) {
     final featureFlagsMap = <String, GenericFeatureFlag>{};
 
     for (final featureFlag in featureFlags) {
@@ -53,12 +55,12 @@ class FeatureFlagTable {
     return _controller!.isEnabled(code);
   }
 
-  static void _saveEnabled(String code, {required bool enabled}) {
+  static Future<void> _saveEnabled(String code, {required bool enabled}) async {
     if (_controller == null) {
       throw Exception('FeatureFlagController is not initialized.');
     }
 
-    _controller!.saveEnabled(code, enabled: enabled);
+    await _controller!.saveEnabled(code, enabled: enabled);
   }
 
   static FeatureFlag _createFeatureFlag(FeatureFlagInfo featureFlagInfo) {
@@ -74,7 +76,8 @@ class FeatureFlagTable {
   }
 
   static GenericFeatureFlag _createFeatureFlagGroup(
-      FeatureFlagGroupInfo featureFlagGroupInfo) {
+    FeatureFlagGroupInfo featureFlagGroupInfo,
+  ) {
     final code = featureFlagGroupInfo.code;
     final getName = featureFlagGroupInfo.getName;
     final featureFlags =
@@ -84,12 +87,7 @@ class FeatureFlagTable {
       code: code,
       getName: getName,
       isEnabled: () => _isEnabled(code),
-      saveEnabled: ({required enabled}) {
-        _saveEnabled(code, enabled: enabled);
-        for (final featureFlag in featureFlags) {
-          featureFlag.enabled = enabled;
-        }
-      },
+      saveEnabled: ({required enabled}) => _saveEnabled(code, enabled: enabled),
       featureFlags: featureFlags,
     );
 

packages/uni_app/lib/model/feature_flags/feature_flag.dart

@@ -6,7 +6,7 @@ class FeatureFlag extends GenericFeatureFlag {
     required this.code,
     required String Function(BuildContext) getName,
     required bool Function() isEnabled,
-    required void Function({required bool enabled}) saveEnabled,
+    required Future<void> Function({required bool enabled}) saveEnabled,
   })  : _getName = getName,
         _isEnabled = isEnabled,
         _saveEnabled = saveEnabled;
@@ -15,16 +15,15 @@ class FeatureFlag extends GenericFeatureFlag {
   final String code;
   final String Function(BuildContext) _getName;
   final bool Function() _isEnabled;
-  final void Function({required bool enabled}) _saveEnabled;
+  final Future<void> Function({required bool enabled}) _saveEnabled;
 
   @override
   String getName(BuildContext context) => _getName(context);
 
   @override
-  bool get enabled => _isEnabled();
+  bool isEnabled() => _isEnabled();
 
   @override
-  set enabled(bool enabled) {
-    _saveEnabled(enabled: enabled);
-  }
+  Future<void> setEnabled({required bool enabled}) =>
+      _saveEnabled(enabled: enabled);
 }

packages/uni_app/lib/model/feature_flags/feature_flag_group.dart

@@ -7,7 +7,7 @@ class FeatureFlagGroup extends GenericFeatureFlag {
     required this.code,
     required String Function(BuildContext) getName,
     required bool Function() isEnabled,
-    required void Function({required bool enabled}) saveEnabled,
+    required Future<void> Function({required bool enabled}) saveEnabled,
     required List<FeatureFlag> featureFlags,
   })  : _getName = getName,
         _isEnabled = isEnabled,
@@ -18,21 +18,21 @@ class FeatureFlagGroup extends GenericFeatureFlag {
   final String code;
   final String Function(BuildContext) _getName;
   final bool Function() _isEnabled;
-  final void Function({required bool enabled}) _saveEnabled;
+  final Future<void> Function({required bool enabled}) _saveEnabled;
   final List<FeatureFlag> _featureFlags;
 
   @override
   String getName(BuildContext context) => _getName(context);
 
   @override
-  bool get enabled => _isEnabled();
+  bool isEnabled() => _isEnabled();
 
   @override
-  set enabled(bool enabled) {
-    _saveEnabled(enabled: enabled);
+  Future<void> setEnabled({required bool enabled}) async {
+    await _saveEnabled(enabled: enabled);
 
     for (final featureFlag in _featureFlags) {
-      featureFlag.enabled = enabled;
+      await featureFlag.setEnabled(enabled: enabled);
     }
   }
 

packages/uni_app/lib/model/feature_flags/generic_feature_flag.dart

@@ -3,6 +3,6 @@ import 'package:flutter/material.dart';
 abstract class GenericFeatureFlag {
   String get code;
   String getName(BuildContext context);
-  bool get enabled;
-  set enabled(bool enabled);
+  bool isEnabled();
+  Future<void> setEnabled({required bool enabled});
 }

packages/uni_app/lib/view/settings/widgets/feature_flags/feature_flags_dialog.dart

@@ -1,8 +1,8 @@
 import 'package:flutter/material.dart';
-import 'package:shared_preferences/shared_preferences.dart';
 import 'package:uni/controller/feature_flags/feature_flag_table.dart';
 
 import 'package:uni/generated/l10n.dart';
+import 'package:uni/view/settings/widgets/feature_flags/feature_switch_tile.dart';
 
 class FeatureFlagsDialog extends StatefulWidget {
   const FeatureFlagsDialog({super.key});
@@ -12,32 +12,29 @@ class FeatureFlagsDialog extends StatefulWidget {
 }
 
 class FeatureFlagsDialogState extends State<FeatureFlagsDialog> {
-  late Future<SharedPreferences> _preferences;
-
   @override
   void initState() {
     super.initState();
-    _preferences = SharedPreferences.getInstance();
+  }
+
+  void refresh() {
+    setState(() {});
   }
 
   @override
   Widget build(BuildContext context) {
     return AlertDialog(
       title: Text(S.of(context).feature_flags),
-      content: FutureBuilder<SharedPreferences>(
-        future: _preferences,
-        builder: (context, snapshot) {
-          if (!snapshot.hasData) {
-            return Container();
-          }
-
-          return Column(
-            mainAxisSize: MainAxisSize.min,
-            children: FeatureFlagTable.getFeatureFlags()
-                .map((featureFlag) => Text(featureFlag.getName(context)))
-                .toList(),
-          );
-        },
+      content: Column(
+        mainAxisSize: MainAxisSize.min,
+        children: FeatureFlagTable.getFeatureFlags()
+            .map(
+              (featureFlag) => FeatureSwitchTile(
+                featureFlag: featureFlag,
+                refreshDialog: refresh,
+              ),
+            )
+            .toList(),
       ),
     );
   }

packages/uni_app/lib/view/settings/widgets/feature_flags/feature_switch_tile.dart

@@ -0,0 +1,27 @@
+import 'package:flutter/material.dart';
+import 'package:uni/model/feature_flags/generic_feature_flag.dart';
+
+class FeatureSwitchTile extends StatelessWidget {
+  const FeatureSwitchTile({
+    required this.featureFlag,
+    required this.refreshDialog,
+    super.key,
+  });
+
+  final GenericFeatureFlag featureFlag;
+  final void Function() refreshDialog;
+
+  @override
+  Widget build(BuildContext context) {
+    return ListTile(
+      title: Text(featureFlag.getName(context)),
+      trailing: Switch.adaptive(
+        value: featureFlag.isEnabled(),
+        onChanged: (value) async {
+          await featureFlag.setEnabled(enabled: value);
+          refreshDialog();
+        },
+      ),
+    );
+  }
+}