Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused months removal #1002

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Unused months removal #1002

merged 1 commit into from
Oct 10, 2023

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Oct 6, 2023

Closes #996
Removes months variable, which was not used.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1002 (47736bb) into develop (012aa85) will decrease coverage by 6%.
Report is 41 commits behind head on develop.
The diff coverage is 12%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #1002     +/-   ##
=========================================
- Coverage       23%     16%     -6%     
=========================================
  Files          143     201     +58     
  Lines         4349    6361   +2012     
=========================================
+ Hits           964     986     +22     
- Misses        3385    5375   +1990     

@LuisDuarte1 LuisDuarte1 merged commit 226465f into develop Oct 10, 2023
4 checks passed
@LuisDuarte1 LuisDuarte1 deleted the fix/remove-unused-months branch October 10, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete unused months in AppExamsDatabase
3 participants