Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bottom navbar #1306

Merged
merged 20 commits into from
Oct 19, 2024
Merged

New bottom navbar #1306

merged 20 commits into from
Oct 19, 2024

Conversation

Process-ing
Copy link
Contributor

@Process-ing Process-ing commented Aug 27, 2024

Closes #1267

It adds the new bottom navbar. To use it, the app needs to provide the navbar items, along with their icons and desired behaviors.

Screenshot_1724862673

I also added a slight splash effect when clicked. If you think it should be removed, let me know.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12%. Comparing base (b6a2e08) to head (c721483).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1306   +/-   ##
=======================================
+ Coverage       12%     12%   +1%     
=======================================
  Files          266     266           
  Lines         7194    7198    +4     
=======================================
+ Hits           802     803    +1     
- Misses        6392    6395    +3     

@Process-ing Process-ing marked this pull request as ready for review August 28, 2024 16:37
@Process-ing Process-ing requested a review from a team August 28, 2024 16:37
@Process-ing Process-ing changed the title Feature/new bottom navbar New bottom navbar Aug 28, 2024
@Process-ing Process-ing force-pushed the feature/new-bottom-navbar branch 2 times, most recently from b291802 to 00cb378 Compare September 11, 2024 19:48
@DGoiana DGoiana requested review from a team September 11, 2024 21:43
Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool work here! 💯

@Process-ing Process-ing merged commit 750ff30 into develop Oct 19, 2024
6 checks passed
@Process-ing Process-ing deleted the feature/new-bottom-navbar branch October 19, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar
3 participants