-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bottom navbar #1306
Merged
Merged
New bottom navbar #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1306 +/- ##
=======================================
+ Coverage 12% 12% +1%
=======================================
Files 266 266
Lines 7194 7198 +4
=======================================
+ Hits 802 803 +1
- Misses 6392 6395 +3 |
thePeras
reviewed
Aug 29, 2024
Process-ing
force-pushed
the
feature/new-bottom-navbar
branch
2 times, most recently
from
September 11, 2024 19:48
b291802
to
00cb378
Compare
thePeras
approved these changes
Sep 12, 2024
Process-ing
force-pushed
the
feature/new-bottom-navbar
branch
from
October 2, 2024 16:17
00cb378
to
8c6e3cc
Compare
DGoiana
reviewed
Oct 15, 2024
DGoiana
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool work here! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1267
It adds the new bottom navbar. To use it, the app needs to provide the navbar items, along with their icons and desired behaviors.
I also added a slight splash effect when clicked. If you think it should be removed, let me know.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change