Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore #1368

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Update .gitignore #1368

merged 2 commits into from
Oct 24, 2024

Conversation

pratyush-1327
Copy link
Contributor

Added pubspec.lock

Closes #1367
Added pubspec.lock to gitignore

Review checklist

  • [-] Terms and conditions reflect the current change
  • [-] Contains enough appropriate tests
  • [-] If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • [-] Properly adds an entry in changelog.md with the change
  • [-] If PR includes UI updates/additions, its description has screenshots
  • [-] Behavior is as expected
  • [-] Clean, well-structured code

@DGoiana
Copy link
Collaborator

DGoiana commented Oct 23, 2024

Hi! @pratyush-1327, thanks for your first contribution. Not adding pubspec.lock to remote was actually a topic that the team discussed a couple of months ago. Check this link to see why we've decided to commit the .lock.

@pratyush-1327
Copy link
Contributor Author

Oh okay., but the issue was still open for the exact thing so I opened the PR

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12%. Comparing base (a0ceb98) to head (e9354de).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1368   +/-   ##
=======================================
  Coverage       12%     12%           
=======================================
  Files          266     266           
  Lines         7198    7198           
=======================================
  Hits           803     803           
  Misses        6395    6395           

@DGoiana
Copy link
Collaborator

DGoiana commented Oct 24, 2024

After discussing it with the team, we agreed on accepting your contribution! Thank you!

@DGoiana DGoiana merged commit ae6539a into NIAEFEUP:develop Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pubspec.lock to .gitignore in uni_ui
4 participants