Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sentry auth exception #1387

Merged
merged 5 commits into from
Nov 11, 2024
Merged

fix: sentry auth exception #1387

merged 5 commits into from
Nov 11, 2024

Conversation

peucastro
Copy link
Member

Closes #1371
This pull request aims to stop sending expiredCredentials, internetError, and wrongCredentials exceptions to Sentry. Note that now the reason is not conveyed to the user anymore.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (249fc86) to head (bc5ba1c).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1387   +/-   ##
=======================================
- Coverage       12%     12%   -0%     
=======================================
  Files          266     265    -1     
  Lines         7201    7209    +8     
=======================================
  Hits           806     806           
- Misses        6395    6403    +8     

packages/uni_app/lib/view/login/login.dart Outdated Show resolved Hide resolved
packages/uni_app/lib/view/login/login.dart Outdated Show resolved Hide resolved
@peucastro peucastro changed the title Fix/sentry auth exception fix: sentry auth exception Nov 9, 2024
@peucastro peucastro marked this pull request as ready for review November 9, 2024 12:03
Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work 🚀

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@thePeras thePeras merged commit 1da2fbf into develop Nov 11, 2024
6 checks passed
@thePeras thePeras deleted the fix/sentry-auth-exception branch November 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AuthenticationExceptionType.wrongCredentials to be sent to Sentry
3 participants