-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sentry auth exception #1387
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1387 +/- ##
=======================================
- Coverage 12% 12% -0%
=======================================
Files 266 265 -1
Lines 7201 7209 +8
=======================================
Hits 806 806
- Misses 6395 6403 +8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Closes #1371
This pull request aims to stop sending expiredCredentials, internetError, and wrongCredentials exceptions to Sentry. Note that now the reason is not conveyed to the user anymore.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change