-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/aggressive linter #863
Ci/aggressive linter #863
Conversation
On this pr, I think it's appropriate to focus on making the linter pass without altering the app logic/architecture a lot. So, some rules were ignored that must be addressed in the future, and some calls to |
Absolutely |
72aacdd
to
6a1324c
Compare
I have found that some things are still not ready, such as the test timing out and the course units page details not working. I'll draft this while these are not tackled, let me know if you find something @LuisDuarte1. |
@LuisDuarte1 I can't reproduce the course units detail page being broken on develop, however, I made the parser stricter here and fixed a bug you had on the query parameters parser. Please let me know if it is fixed for you now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't read thoroughly trough the code because of the large amount of changes. However, I tried to test every feature and submitted my feedback and correction suggestions to @bdmendes, who has already integrated them.
Good job all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I have tested, the app looks to be working as it should and the code looks good. Great job!
P.S.: Rip double quote :')
Closes #820
This sets up the very good analysis linter ruleset for the project, which enforces Dart's strict type-checking rules and more opinionated Flutter linting and formatting.
Although requiring a steeper adaptation to the project and the language, this will improve our consistency and allow for easier reviews and higher code quality overall.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change