-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom navbar and new top navbar #902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the implementation quite a lot.
Two nitpicks:
- Does it make sense that the navbar items are in the
utils
directory? - We are now referencing routes in even more places: besides on card tap actions and drawer links, we now have bottom nav bar links. Can we encapsulate a route in a enum with a string?
|
9b43d32
to
c9aeaa2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #902 +/- ##
======================================
+ Coverage 16% 16% +1%
======================================
Files 225 227 +2
Lines 6851 6839 -12
======================================
+ Hits 1053 1062 +9
+ Misses 5798 5777 -21 |
ef70105
to
024d075
Compare
@Process-ing is this ready? If so, please undraft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(dummy request changes to avoid getting merged until the release)
43e6780
to
d2ed63a
Compare
024d075
to
582b521
Compare
582b521
to
0693d1a
Compare
From last design meeting, we'll probably end up with:
|
0693d1a
to
15e9186
Compare
b1a71c7
to
7b606cc
Compare
@Process-ing can you update the PR screenshots with the new design? |
a1261ac
to
b200bff
Compare
LGTM 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #819, closes #1066
The bottom navbar is based on the new redesign of the app, so the pages don't fully match. I also took the freedom to refactor all the pages with the new top navbar style, although it will be probably scrapped for most pages
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change