-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests null safe #904
Make tests null safe #904
Conversation
eda7389
to
2a38386
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #904 +/- ##
======================================
+ Coverage 22% 22% +1%
======================================
Files 136 136
Lines 3532 3536 +4
======================================
+ Hits 746 760 +14
+ Misses 2786 2776 -10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't got a chance to review this thoroughly, but for now do not forget to update the flutter version in the deploy action too
It was already done |
It's still 3.7.2 here, am I missing something? |
Sorry I forgot to push ahahah done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we add documentation about the build runner step in
uni/README.md
? - Should we exclude
*.mocks.dart
from linting and coverage analyzers?
I agree I'll do it, and maybe in the future we should write proper documentation on how to write tests on flutter, to help future contributors, but it should be done separately.
Not sure if coverage will be affected, since the coverage should only be analyzed in the |
I'll make sure to write something about testing in my presentation slides later this September. We can then base the proper docs on it |
88a8289
to
46c06b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick grammar police before getting this merged
25b2a0d
to
006e281
Compare
43e6780
to
d2ed63a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go 🚀
Closes #513
This also updates flutter and dart sdk (because newer versions of mockito need it).
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change