Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target sdk version #920

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

bdmendes
Copy link
Member

Bumps target version to comply with Google's policy.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #920 (e7ccb01) into develop (40311a2) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           develop   #920   +/-   ##
======================================
  Coverage       22%    22%           
======================================
  Files          136    136           
  Lines         3511   3511           
======================================
  Hits           746    746           
  Misses        2765   2765           

Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should target the master branch instead, because if we merge it on develop, we wouldn't still comply with Google's policy at the end of the month

@bdmendes
Copy link
Member Author

Maybe this should target the master branch instead, because if we merge it on develop, we wouldn't still comply with Google's policy at the end of the month

Well, since we won't need to hotfix anything on the release channel outside of the usual flow, the next time we update the release channel it will be from develop, so this will be there. Am I missing something?

@LuisDuarte1
Copy link
Member

LuisDuarte1 commented Aug 20, 2023

Well, since we won't need to hotfix anything on the release channel outside of the usual flow, the next time we update the release channel it will be from develop, so this will be there. Am I missing something?

Maybe the wording on the Google Play Console is a bit weird, but it says: "You won't be able to release app updates".

image

There's no real consequence of releasing an update which only updates the SDK version, so I prefer if we do it now ^^

@bdmendes
Copy link
Member Author

bdmendes commented Aug 20, 2023

I missed that discoverability part. Let me change the target branch then
(Edit: looks like there is no way without bringing the whole history, so let's merge this first and then cherry pick from develop, is that ok @LuisDuarte1?)

@bdmendes bdmendes changed the base branch from develop to master August 20, 2023 13:49
@bdmendes bdmendes changed the base branch from master to develop August 20, 2023 13:49
@LuisDuarte1
Copy link
Member

I missed that discoverability part. Let me change the target branch then (Edit: looks like there is no way without bringing the whole history, so let's merge this first and then cherry pick from develop, is that ok @LuisDuarte1?)

Yeah we can do that ^^

@bdmendes bdmendes force-pushed the hotfix/bump-target-android-api branch 3 times, most recently from 119e96e to e7ccb01 Compare August 24, 2023 13:46
@bdmendes bdmendes force-pushed the hotfix/bump-target-android-api branch from e7ccb01 to 800ce69 Compare August 31, 2023 18:28
@bdmendes bdmendes merged commit ec7643e into develop Aug 31, 2023
3 checks passed
@bdmendes bdmendes deleted the hotfix/bump-target-android-api branch August 31, 2023 18:29
@bdmendes bdmendes mentioned this pull request Aug 31, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants