Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar parsing #924

Merged
merged 8 commits into from
Sep 10, 2023
Merged

Fix calendar parsing #924

merged 8 commits into from
Sep 10, 2023

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Aug 20, 2023

Closes #899
Fixed a &nbsp error in the calendar parsing

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana linked an issue Aug 20, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #924 (9087e05) into develop (86a2078) will decrease coverage by 0%.
Report is 1 commits behind head on develop.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           develop   #924   +/-   ##
======================================
- Coverage       22%    22%   -0%     
======================================
  Files          136    136           
  Lines         3536   3539    +3     
======================================
  Hits           759    759           
- Misses        2777   2780    +3     

Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done at the parser level, imo

thePeras
thePeras previously approved these changes Aug 25, 2023
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to create multiple auxiliary variables to filter the collection. Inlining will make this easier to read

@thePeras thePeras merged commit ed44c6a into develop Sep 10, 2023
6 checks passed
@thePeras thePeras deleted the fix/calendar-parsing branch September 10, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix calendar parsing
3 participants