-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calendar parsing #924
Fix calendar parsing #924
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #924 +/- ##
======================================
- Coverage 22% 22% -0%
======================================
Files 136 136
Lines 3536 3539 +3
======================================
Hits 759 759
- Misses 2777 2780 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done at the parser level, imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to create multiple auxiliary variables to filter the collection. Inlining will make this easier to read
437f379
to
d514742
Compare
The merge-base changed after approval.
43e6780
to
d2ed63a
Compare
bd342f3
to
4cbe514
Compare
Closes #899
Fixed a   error in the calendar parsing
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change