-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change credentials storage to FlutterSecureStorage and remove WillPopScope #935
Conversation
Hey @Sanat2002, |
Changed the flutter secure storage version. Review this one again so I can fix the problem if it is generated again. Review checklist
|
Removed the unused import . Run the check again please |
@Sanat2002 you can edit the original PR comment instead of creating a new one. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #935 +/- ##
======================================
+ Coverage 22% 22% +1%
======================================
Files 136 136
Lines 3549 3537 -12
======================================
Hits 761 761
+ Misses 2788 2776 -12 |
As a side advice, it's best not to fix two unrelated issues in the same PR like this. It makes it more difficult to reason about the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The secure credentials are working well, however there is still an exit confirmation on the app. Search for WillPopScope
7209a13
to
6c7ca8f
Compare
Dear @Sanat2002, we'll be working on this due to the lack of activity. Thanks for your contribution! |
Issue #[873,851]
The WillPopScope is removed from the first route and the userCrendentials are secured utilizing flutter secure storage , all read and delete operations on the userCrendentials have been modified accordingly.