Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back to School 2023 Release #965

Merged
merged 713 commits into from
Sep 26, 2023
Merged

Back to School 2023 Release #965

merged 713 commits into from
Sep 26, 2023

Conversation

bdmendes
Copy link
Member

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

bdmendes and others added 30 commits July 21, 2023 19:17
@bdmendes
Surpress warnings from models
47e5203
@thePeras
Merge remote-tracking branch 'origin/develop' into ci/format-job
44b5d76
@thePeras
Update GitHub actions versions
c5871bb
@bdmendes
Implemented job to check if code is formated (#853) [no ci]
6bc8c19
@bdmendes
Update README.md
0ff1f0d
@LuisDuarte1
Add pre-commit hook
9f87b00
@LuisDuarte1
More models and fix startup providers
1cc4b61
@thePeras
Merge branch 'develop' into feature/change-ni-logo-color
5097e42
@LuisDuarte1
bus_stop and text_field fixed
60cd7c1
@LuisDuarte1
Fix most cards
eeb9f04
@bdmendes
Merge branch 'develop' into refactor/remove-completers
ca1bc6f
@Sirze01
Increase default timeout to 10s and add parameterized timeout
d130c6b
@LuisDuarte1
Remove generated dart files from the pre commit hook
fc49295
@Sirze01
Merge branch 'develop' into fix/get-with-cookies-timeout
4c7bfb1
@Sirze01
Fix readme badges (#865)
7f089b3
@Sirze01
Merge branch 'develop' into feature/change-ni-logo-color
518e313
@Sirze01
Feature/change ni logo color (#840)
8a4a44a
@Sirze01 @github-actions
Bump app version [no ci]
e41da1d
@LuisDuarte1
most of the views done
493133d
@LuisDuarte1
all views without errors
ffe29a9
@bdmendes
Merge branch 'develop' into refactor/remove-completers
7bf4466
@bdmendes
Merge branch 'develop' into fix/get-with-cookies-timeout
071ea0c
@LuisDuarte1
Refactor/remove completers (#849)
a20ef9e
@LuisDuarte1 @github-actions
Bump app version [no ci]
9e4382e
@Sirze01
Make use Duration(s) instead of creating them based on arguments
0858b6a
@bdmendes
Merge branch 'develop' into fix/get-with-cookies-timeout
fd05908
@thePeras
Add timeout to requests made by getWithCookies (#856)
f65fd86
@thePeras @github-actions
Bump app version [no ci]
9197660
@bdmendes
Update update time only if successfull
9870485
@bdmendes
Rewrite method to make it more clear
ee7374c
LuisDuarte1
LuisDuarte1 requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still having the profile provider issue, when I login. I'll try looking into it myself, but marking this as "Changes requested" to prevent the merging until this is solved
image

@bdmendes
Copy link
Member Author

I can't reproduce that, so it must be something specific to your SIGARRA data. Please have a look

LuisDuarte1
LuisDuarte1 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my quick testing, I can't find anything that doesn't work. 🚀 🚀

DGoiana
DGoiana approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good features coming! No bugs found, awesome work 🚀

@jlcrodrigues
Copy link
Contributor

I think there's a translation missing in the exam day. @DGoiana could you confirm this?

uni/uni/lib/view/exams/widgets/day_title.dart

Line 20 in 85d7277

'$weekDay, $day de $month',

Sirze01
Sirze01 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@Sirze01 Sirze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find anything major breaking. Let's release it :).

@bdmendes
Copy link
Member Author

@jlcrodrigues since this is not breaking, could you create an issue and approve this if everything else is working correctly?

@jlcrodrigues jlcrodrigues mentioned this pull request Sep 26, 2023
Closed
@DGoiana
Copy link
Collaborator

DGoiana commented Sep 26, 2023 •
edited
Loading

@jlcrodrigues since this is not breaking, could you create an issue and approve this if everything else is working correctly?

It is already fixed, if you want to merge. #968

jlcrodrigues
jlcrodrigues approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jlcrodrigues jlcrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working on my end!

@bdmendes
Copy link
Member Author

Let's go!

@bdmendes bdmendes merged commit 9e6b7f0 into master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGoiana DGoiana DGoiana approved these changes

@jlcrodrigues jlcrodrigues jlcrodrigues approved these changes

@Sirze01 Sirze01 Sirze01 approved these changes

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@Process-ing Process-ing Awaiting requested review from Process-ing

@thePeras thePeras Awaiting requested review from thePeras

@rubuy-74 rubuy-74 Awaiting requested review from rubuy-74

@coutinho21 coutinho21 Awaiting requested review from coutinho21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bdmendes @jlcrodrigues @DGoiana @LuisDuarte1 @Sirze01 @thePeras @Process-ing @limwa