Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHexagon component #198

Merged
merged 8 commits into from
Nov 6, 2024
Merged

EventHexagon component #198

merged 8 commits into from
Nov 6, 2024

Conversation

MRita443
Copy link
Collaborator

@MRita443 MRita443 commented Jun 21, 2023

Adds HexagonEvent component for use in events listing page (for demo purposes a test page was created in /routes)

Screenshots

Review checklist

  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well-structured code

@MRita443 MRita443 self-assigned this Jun 21, 2023
@MRita443 MRita443 changed the title Feature/hexagon events HexagonEvent component Jun 21, 2023
@MRita443 MRita443 requested a review from DoStini June 21, 2023 21:22
@BrunoRosendo BrunoRosendo linked an issue Jun 28, 2023 that may be closed by this pull request
@BrunoRosendo BrunoRosendo removed a link to an issue Jun 28, 2023
@BrunoRosendo BrunoRosendo linked an issue Jun 28, 2023 that may be closed by this pull request
4 tasks
@MRita443 MRita443 requested a review from limwa July 12, 2023 15:38
@MRita443
Copy link
Collaborator Author

@DoStini I tried to keep this branch up to date with develop, whenever you merge please update yours too

@MRita443 MRita443 changed the title HexagonEvent component EventHexagon component Jul 25, 2023
@MRita443 MRita443 changed the base branch from feature/events-page to develop January 1, 2024 19:35
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b820ff3) 95.21% compared to head (38b4184) 96.11%.

Files Patch % Lines
src/lib/layout/hexagons/EventHexagon.svelte 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #198      +/-   ##
===========================================
+ Coverage    95.21%   96.11%   +0.90%     
===========================================
  Files           20       21       +1     
  Lines          188      206      +18     
  Branches        38       45       +7     
===========================================
+ Hits           179      198      +19     
+ Misses           9        8       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MRita443 MRita443 requested review from LuisDuarte1 and Vidal322 and removed request for limwa and DoStini January 23, 2024 14:36
@MRita443 MRita443 requested a review from Vidal322 July 26, 2024 14:44
@MRita443 MRita443 requested a review from rubuy-74 July 27, 2024 10:44
@MRita443
Copy link
Collaborator Author

@Vidal322 @rubuy-74 @LuisDuarte1 review bump

Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

I don't know if it's possible to see, but the interval event hexagon is larger. This could be a problem, since they are positioned side by side in the events page.

@MRita443
Copy link
Collaborator Author

image image

I don't know if it's possible to see, but the interval event hexagon is larger. This could be a problem, since they are positioned side by side in the events page.

I tested it out and confirmed that in the grid these differences are not there
image

Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@MRita443 MRita443 merged commit 1d31676 into develop Nov 6, 2024
5 checks passed
@MRita443 MRita443 deleted the feature/hexagon-events branch November 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

events: basic listing page
3 participants