Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline Component #220

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Timeline Component #220

wants to merge 6 commits into from

Conversation

LuisDuarte1
Copy link
Member

@LuisDuarte1 LuisDuarte1 commented Aug 9, 2023

Closes #282

Screenshots

Review checklist

  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well-structured code

@LuisDuarte1
Copy link
Member Author

The HorizontalTimeline for now:
image

I've changed the design from the mockups (because it's more intuitive having the arrows for interacting with the timeline imo). wdyt? @MRita443

Also, should I change this PR to be the HorizontalTimeline only? because I think that #163 depends on it

@LuisDuarte1
Copy link
Member Author

LuisDuarte1 commented Sep 24, 2023

There's some things that I still have to consider:

  • Should we change the displayedSize according to width? (must be done on js though)
  • Should we have transition animations? (not sure what kind of animations would be suitable for this)
  • What color should we use to indicate that you can't go futher right/left?
  • Testing the component 😅

@MRita443
Copy link
Collaborator

The HorizontalTimeline for now:
image

I've changed the design from the mockups (because it's more intuitive having the arrows for interacting with the timeline imo). wdyt? @MRita443

Also, should I change this PR to be the HorizontalTimeline only? because I think that #163 depends on it

I also agree this way is more intuitive for knowing there are more years to scroll through, but let's ask @NIAEFEUP/design-website for an opinion too!

If you see the PR is getting large or that it might take you a bit to finish the whole page go ahead and separate it, but I don't think #163 will be worked on for now.

Keep up the good work :)

@MRita443 MRita443 linked an issue Sep 27, 2023 that may be closed by this pull request
2 tasks
Base automatically changed from feature/hexagon-team-members to develop October 8, 2023 13:36
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e45855f) 95.21% compared to head (5b34800) 93.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #220      +/-   ##
===========================================
- Coverage    95.21%   93.60%   -1.61%     
===========================================
  Files           20       21       +1     
  Lines          188      219      +31     
  Branches        38       48      +10     
===========================================
+ Hits           179      205      +26     
- Misses           9       14       +5     
Files Coverage Δ
src/lib/component/Icons.ts 100.00% <ø> (ø)
src/lib/layout/HorizontalTimeline.svelte 83.87% <83.87%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MRita443 MRita443 changed the title Team page layout Timeline Component Jul 25, 2024
@MRita443 MRita443 removed a link to an issue Jul 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants