Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes to foreign data #52

Merged
merged 3 commits into from
Nov 27, 2023
Merged

fixes to foreign data #52

merged 3 commits into from
Nov 27, 2023

Conversation

andybeet
Copy link
Member

@andybeet andybeet commented Nov 27, 2023 •
edited
Loading

CODE

  • Fixes to foreign data to enable integration with "new" stockeff data. (process_foreign_data.r)
  • Replaced TONCL1 with TONCL2 (NAFO data only has single digit tonnage codes that map prety well to TONCL1 so just added second digit of zero to all tonnage classes)
  • Added MARKET_CODE category with defualt NA value
  • Added placeholders for arguments in get_comland_data

@andybeet andybeet requested a review from slucey November 27, 2023 21:06
slucey
slucey approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@slucey slucey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@slucey slucey merged commit 5c0bb16 into switch_stockeff Nov 27, 2023
2 checks passed
@andybeet andybeet deleted the fix_foreign_stockeff branch March 13, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slucey slucey slucey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybeet @slucey