Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up documentation + added function #74

Merged
merged 10 commits into from
Jul 12, 2024
Merged

Cleaned up documentation + added function #74

merged 10 commits into from
Jul 12, 2024

Conversation

andybeet
Copy link
Member

@andybeet andybeet commented Jul 12, 2024

Documentation

  • Expanded pullingData.rmd vignette to explain the main options
  • added sample data for the vignette, documentation, and code to produce it
  • fixed typos in some of the get_ functions
  • expanded readme.rmd to outline who this package is for
  • changed maintainer of package to Andy Beet
  • expanded get_survdat_data.r documentation to explain all of the fields returned

Code

  • added check_argument_validation function to stop the data pull if some of the arguments would cause an error to be thrown later on in the pull

@andybeet andybeet requested a review from sgaichas July 12, 2024 20:40
Copy link
Member

@sgaichas sgaichas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great Andy, thank you. The package and pkgdown website all build for me.

@sgaichas sgaichas merged commit eb23a5f into master Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants